-
Notifications
You must be signed in to change notification settings - Fork 1.2k
all: replace math/rand with math/rand/v2 #6732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
35d4e2d
to
4f8b26e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that we do not want a changelog entry for this change?
I thought about it but it didn't seem to fit the rest of the changelog as there's no real observable change from the end user perspective. |
What about the fact that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I especially like the ID generator fixes.
Please include benchmarks using benchstat in the PR descrition for the files changed that provide existing benchmarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I added a benchstat comparison for the TraceStart benchmarks, not sure if anything else would be affected? |
Unless anyone objects, I will merge this in about 24 hours. |
Update to new stdlib apis.
The new Float64 is uniform, which resolves a long comment.
https://cs.opensource.google/go/go/+/refs/tags/go1.24.2:src/math/rand/v2/rand.go;l=209