Skip to content

otlploghttp: Add WithHTTPClient option #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 7, 2025
Merged

otlploghttp: Add WithHTTPClient option #6688

merged 11 commits into from
May 7, 2025

Conversation

pellared
Copy link
Member

@pellared pellared commented Apr 22, 2025 •
edited
Loading

@pellared pellared mentioned this pull request Apr 22, 2025
Closed
@pellared pellared changed the title otlploghttp: Add WithHTTPClient option [Proposal] otlploghttp: Add WithHTTPClient option Apr 22, 2025
@pellared pellared marked this pull request as ready for review April 23, 2025 05:21
@dmathieu
Copy link
Member

I tend to prefer this approach as well, as it allows overriding both the client and transport.

dmathieu
dmathieu reviewed Apr 23, 2025
View reviewed changes
@pellared pellared changed the title [Proposal] otlploghttp: Add WithHTTPClient option otlploghttp: Add WithHTTPClient option Apr 23, 2025
@pellared
Copy link
Member Author

I tend to prefer this approach as well, as it allows overriding both the client and transport.

Then I am making this as "actual" PR 😉
PTAL

@pellared pellared requested a review from dmathieu April 23, 2025 09:25
This was referenced Apr 23, 2025
Closed
Closed
Closed
@pellared
Copy link
Member Author

@open-telemetry/go-approvers, PTAL

@dmathieu dmathieu mentioned this pull request May 5, 2025
Closed
@pellared pellared merged commit cf8179a into open-telemetry:main May 7, 2025
29 of 30 checks passed
@pellared pellared deleted the log-client branch May 7, 2025 08:54
This was referenced May 7, 2025
Merged
Merged
Open
@pellared pellared added this to the v1.36.0 milestone May 13, 2025
pellared added a commit that referenced this pull request May 13, 2025
@pellared
otlpmetrichttp: Add WithHTTPClient option (#6752)
b665425 
Follows #6688

Towards (for OTLP metric exporter):
- #4536
- #5129
- #2632
pellared added a commit that referenced this pull request May 13, 2025
@pellared
otlptracehttp: Add WithHTTPClient option (#6751)
5cd1611 
Follows #6688

Towards (for OTLP trace exporter):
- #4536
- #5129
- #2632
@dmathieu dmathieu mentioned this pull request May 19, 2025
Merged
dmathieu added a commit that referenced this pull request May 21, 2025
@dmathieu @MrAlias @pellared
Release v1.36.0/v0.58.0/v0.12.0 (#6793)
a85ae98 
# Overview

Closes #6786

### Added

- Add exponential histogram support in
`go.opentelemetry.io/otel/exporters/prometheus`. (#6421)
- The `go.opentelemetry.io/otel/semconv/v1.31.0` package.
The package contains semantic conventions from the `v1.31.0` version of
the OpenTelemetry Semantic Conventions.
See the [migration documentation](./semconv/v1.31.0/MIGRATION.md) for
information on how to upgrade from
`go.opentelemetry.io/otel/semconv/v1.30.0`. (#6479)
- Add `Recording`, `Scope`, and `Record` types in
`go.opentelemetry.io/otel/log/logtest`. (#6507)
- Add `WithHTTPClient` option to configure the `http.Client` used by
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`.
(#6751)
- Add `WithHTTPClient` option to configure the `http.Client` used by
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`.
(#6752)
- Add `WithHTTPClient` option to configure the `http.Client` used by
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#6688)
- Add `ValuesGetter` in `go.opentelemetry.io/otel/propagation`, a
`TextMapCarrier` that supports retrieving multiple values for a single
key. (#5973)
- Add `Values` method to `HeaderCarrier` to implement the new
`ValuesGetter` interface in `go.opentelemetry.io/otel/propagation`.
(#5973)
- Update `Baggage` in `go.opentelemetry.io/otel/propagation` to retrieve
multiple values for a key when the carrier implements `ValuesGetter`.
(#5973)
- Add `AssertEqual` function in `go.opentelemetry.io/otel/log/logtest`.
(#6662)
- The `go.opentelemetry.io/otel/semconv/v1.32.0` package.
The package contains semantic conventions from the `v1.32.0` version of
the OpenTelemetry Semantic Conventions.
See the [migration documentation](./semconv/v1.32.0/MIGRATION.md) for
information on how to upgrade from
`go.opentelemetry.io/otel/semconv/v1.31.0`(#6782)
- Add `Transform` option in `go.opentelemetry.io/otel/log/logtest`.
(#6794)
- Add `Desc` option in `go.opentelemetry.io/otel/log/logtest`. (#6796)

### Removed

- Drop support for [Go 1.22]. (#6381, #6418)
- Remove `Resource` field from `EnabledParameters` in
`go.opentelemetry.io/otel/sdk/log`. (#6494)
- Remove `RecordFactory` type from
`go.opentelemetry.io/otel/log/logtest`. (#6492)
- Remove `ScopeRecords`, `EmittedRecord`, and `RecordFactory` types from
`go.opentelemetry.io/otel/log/logtest`. (#6507)
- Remove `AssertRecordEqual` function in
`go.opentelemetry.io/otel/log/logtest`, use `AssertEqual` instead.
(#6662)

### Changed

- ⚠️ Update `github.com/prometheus/client_golang` to `v1.21.1`, which
changes the `NameValidationScheme` to `UTF8Validation`.
This allows metrics names to keep original delimiters (e.g. `.`), rather
than replacing with underscores.
This can be reverted by setting
`github.com/prometheus/common/model.NameValidationScheme` to
`LegacyValidation` in `github.com/prometheus/common/model`. (#6433)
- Initialize map with `len(keys)` in `NewAllowKeysFilter` and
`NewDenyKeysFilter` to avoid unnecessary allocations in
`go.opentelemetry.io/otel/attribute`. (#6455)
- `go.opentelemetry.io/otel/log/logtest` is now a separate Go module.
(#6465)
- `go.opentelemetry.io/otel/sdk/log/logtest` is now a separate Go
module. (#6466)
- `Recorder` in `go.opentelemetry.io/otel/log/logtest` no longer
separately stores records emitted by loggers with the same
instrumentation scope. (#6507)
- Improve performance of `BatchProcessor` in
`go.opentelemetry.io/otel/sdk/log` by not exporting when exporter cannot
accept more. (#6569, #6641)

### Deprecated

- Deprecate support for `model.LegacyValidation` for
`go.opentelemetry.io/otel/exporters/prometheus`. (#6449)

### Fixes

- Stop percent encoding header environment variables in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc` and
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#6392)
- Ensure the `noopSpan.tracerProvider` method is not inlined in
`go.opentelemetry.io/otel/trace` so the `go.opentelemetry.io/auto`
instrumentation can instrument non-recording spans. (#6456)
- Use a `sync.Pool` instead of allocating `metricdata.ResourceMetrics`
in `go.opentelemetry.io/otel/exporters/prometheus`. (#6472)

---------

Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@XSAM XSAM XSAM approved these changes

@ysolomchenko ysolomchenko ysolomchenko approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.36.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pellared @dmathieu @XSAM @ysolomchenko