Clarify comments for the WithRetry option in exporters
#6670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
changed the title
WithRetry option in exporters
XSAM
requested review from
MrAlias,
dashpole,
pellared and
dmathieu
as code owners
dmathieu
reviewed
Apr 16, 2025
MrAlias
approved these changes
Apr 16, 2025
dmathieu
approved these changes
Apr 17, 2025
pellared
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since I last looked at the comment about retries. After re-reading it, I initially assumed the gRPC retry logic was handled by the gRPC library itself, but it's actually implemented in our code.
I want to update the comment to make it clearer.