Skip to content

Remove unused get_main_pkgs.sh script #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 28, 2025
Merged

Remove unused get_main_pkgs.sh script #6555

merged 6 commits into from
Mar 28, 2025

Conversation

meyank-ssh
Copy link
Contributor

This PR removes the get_main_pkgs.sh script as it is no longer used in the project.

Closes #6526.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 27, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@meyank-ssh meyank-ssh mentioned this pull request Mar 27, 2025
Closed
@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 27, 2025
dmathieu
dmathieu reviewed Mar 27, 2025
View reviewed changes
@meyank-ssh
Copy link
Contributor Author

Hi @dmathieu , thanks for the approval!
Could you please also approve the pending workflows so the checks can run? That should unblock the merge.

@meyank-ssh
Copy link
Contributor Author

Everything’s green now! ✅
@dmathieu @MrAlias, would you mind merging the PR when you get a chance? Thanks again for the review and help! 🙏

@MrAlias
Copy link
Contributor

MrAlias commented Mar 27, 2025

@meyank-ssh thanks for the contribution. This PR needs to remain open for a full working day before it can be merged. Please see the contributing docs for all the requirements to get a PR merged. It looks like you have enough reviews and the only thing we are waiting for is time at this point. Thanks again.

@dmathieu dmathieu merged commit 2e21e19 into open-telemetry:main Mar 28, 2025
28 of 29 checks passed
@meyank-ssh meyank-ssh deleted the remove-get-main-pkgs branch March 28, 2025 14:19
@MrAlias MrAlias added this to the v1.36.0 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v1.36.0
Development

Successfully merging this pull request may close these issues.

Remove the get_main_pkgs.sh script
4 participants
@meyank-ssh @MrAlias @dmathieu @pellared