-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Integrate go-build-tools crosslink #2886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate go-build-tools crosslink #2886
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2886 +/- ##
=====================================
Coverage 75.7% 75.7%
=====================================
Files 177 177
Lines 11819 11819
=====================================
+ Hits 8950 8954 +4
+ Misses 2636 2632 -4
Partials 233 233
|
At first glance, it seems the most effective approach. Any downsides if we do that? |
There really isn't any in this context. While it's a destructive action the repository is already under version control so it's all completely reversible. Also, continually pruning would ensure that the |
Updates the
crosslink
target to reference thego.opentelemetry.io/build-tools/crosslink
package found here.I have also ran
crosslink prune
to remove all the extraneous replace statements. No make target was added forcrosslink prune
but if desired we could either add a new target for that or pass in the--prune
flag so that a prune is executed on every run.Fixes #1529