Replace net/http Request.pat.str with Request.Pattern #2090
+201
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
txabman42
commented
Apr 3, 2025
txabman42
force-pushed
the
xabier/replace-nethttp-pat
branch
from
0b57d3f to
bd494c3
Compare
grcevski
reviewed
Apr 3, 2025
internal/pkg/instrumentation/bpf/net/http/server/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
txabman42
force-pushed
the
xabier/replace-nethttp-pat
branch
2 times, most recently
from
04c9f20 to
d342f5f
Compare
Request.pat.str was made public via Request.Pattern in go1.23 (golang/go@a523152)
net/http ServerMux pattern is supported for go1.22 which relay in Request.pat.str private fields.
txabman42
force-pushed
the
xabier/replace-nethttp-pat
branch
from
7e32d15 to
fde72f4
Compare
RonFed
reviewed
Apr 16, 2025
internal/pkg/instrumentation/bpf/net/http/server/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
internal/pkg/instrumentation/bpf/net/http/server/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
MrAlias
reviewed
Apr 17, 2025
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Ron Federman <[email protected]>
private/public pattern field.
RonFed
approved these changes
Apr 18, 2025
MrAlias
approved these changes
Apr 18, 2025
grcevski
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request.pat.strwas made public viaRequest.Patternin go1.23It's just a small change to not depend for internal properties if public ones could be used. A bit more simple and avoid being affected by some internal refactors.