-
Notifications
You must be signed in to change notification settings - Fork 112
fix: add cross-platform perf reader implementation and fix type mismatch #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: add cross-platform perf reader implementation and fix type mismatch #1969
Conversation
…tches - Created platform-specific implementations for perf reader with Linux implementation using github.com/cilium/ebpf/perf and stub implementations for non-Linux platforms - Fixed type mismatches by updating process.TargetDetails to process.Info in bpffs package - Changed GetCPUCount return type from int to uint64 for consistency - Improved documentation for kernel lockdown mode constants - Updated import statements to use the new internal perf package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the perf
change.
It broke because of cilium/ebpf#1650
From the cilium slack it looks like it broke other stuff as well.
I'm not sure if we need to create these stubs here or it should be handled upstream in the cilium library.
Opened cilium/ebpf#1746 |
Seeing the issue linked above is resolved, I think we can remove the perf stubs from this PR. |
Should we update to a commit hash version of that package to support this? |
we could wait for an official release, not sure how much time that would take. |
Issue
Errors encountered during local make build on non Linux System.
Although the expectation is to use docker images or virtual OS, thought this might help clear the obvious build issues.
Environment
To Reproduce
Steps to reproduce the behavior:
make build
Expected behavior
Expected make build to be successful on non linux systems too as the mock implementation is already present
Changes