Skip to content

Add pipeline.Handler #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 11, 2025
Merged

Add pipeline.Handler #1859

merged 21 commits into from
Apr 11, 2025

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 21, 2025 •
edited
Loading

Part of #1398

Adds a new pipeline package to the auto package. This package contains a new Handler interface that is used by the auto.Instrumentation to handle export of telemetry.

@MrAlias MrAlias force-pushed the handler-pkg branch 8 times, most recently from 80e2c07 to 8d31960 Compare February 24, 2025 18:24
@MrAlias MrAlias changed the title Add the handler package Add export.Handler Feb 24, 2025
@MrAlias MrAlias force-pushed the handler-pkg branch 4 times, most recently from 1840d60 to b0f8ad0 Compare February 24, 2025 22:03
@MrAlias MrAlias marked this pull request as ready for review February 24, 2025 22:04
@MrAlias MrAlias requested a review from a team as a code owner February 24, 2025 22:04
@MrAlias MrAlias force-pushed the handler-pkg branch 2 times, most recently from bf5697b to 747f87b Compare February 25, 2025 17:16
RonFed
RonFed reviewed Feb 26, 2025
View reviewed changes
MrAlias
MrAlias commented Feb 27, 2025
View reviewed changes
@MrAlias MrAlias force-pushed the handler-pkg branch 2 times, most recently from cb475bb to 1a2310e Compare February 28, 2025 18:06
RonFed
RonFed reviewed Mar 2, 2025
View reviewed changes
@MrAlias MrAlias force-pushed the handler-pkg branch 7 times, most recently from 9a57c35 to 7892744 Compare March 5, 2025 18:31
MrAlias added 9 commits March 24, 2025 12:21
@MrAlias
Update Instrumentation to use export.Handler
c98b23f 
Remove the internal Controller. Replace its usage with the
export.Handler.

Remove configuration for the OTel SDK setup that now resides in the
otelsdk package.
@MrAlias
Update the cli to manage own handler
c0ca423
@MrAlias
Add a changelog entry
a8675af
@MrAlias
Return an error from Handle
6515371
@MrAlias
Revert "Return an error from Handle"
96212e4 
This reverts commit 07f6558.
@MrAlias
Document the Handler.Handle method
112f30a
@MrAlias
Replace Handler type
9ee5dee 
Use a concrete Handler struct with fields for each signal of handling.

Remove the export.Telemetry type.
@MrAlias
Correctly support resource process attrs
537dc99
@MrAlias
Match upstream use of autoexport
e26968e
@MrAlias MrAlias changed the title Add export.Handler Add pipeline.Handler Mar 25, 2025
RonFed
RonFed approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@RonFed RonFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrote a few nits, looks great 🚀

@MrAlias MrAlias merged commit 854f2d2 into open-telemetry:main Apr 11, 2025
21 checks passed
@MrAlias MrAlias deleted the handler-pkg branch April 11, 2025 20:22
This was referenced Apr 11, 2025
Merged
Closed
Open
@MrAlias MrAlias added this to the v0.22.0 milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@pellared pellared pellared left review comments

@RonFed RonFed RonFed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MrAlias @damemi @pellared @RonFed