Skip to content

chore(otelgin): rename files for improved clarity and consistency #6786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

flc1125
Copy link
Member

@flc1125 flc1125 commented Feb 15, 2025

@github-actions github-actions bot requested a review from akats7 February 15, 2025 15:36
@flc1125 flc1125 marked this pull request as ready for review February 15, 2025 15:39
@flc1125 flc1125 requested a review from a team as a code owner February 15, 2025 15:39
@MrAlias MrAlias added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Feb 15, 2025
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is technically "the correct naming", but seems like an okay change.

@flc1125
Copy link
Member Author

flc1125 commented Feb 17, 2025

Not sure this is technically "the correct naming", but seems like an okay change.

It may not be the best name in terms of technology. More to unify it with other packages.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5%. Comparing base (a3c993d) to head (8526574).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6786   +/-   ##
=====================================
  Coverage   75.5%   75.5%           
=====================================
  Files        206     206           
  Lines      19181   19181           
=====================================
+ Hits       14484   14487    +3     
+ Misses      4259    4257    -2     
+ Partials     438     437    -1     
Files with missing lines Coverage Δ
...ntation/github.com/gin-gonic/gin/otelgin/config.go 100.0% <ø> (ø)
...umentation/github.com/gin-gonic/gin/otelgin/gin.go 92.4% <ø> (ø)

... and 1 file with indirect coverage changes

@dmathieu dmathieu merged commit 06d425e into open-telemetry:main Feb 19, 2025
31 checks passed
@flc1125 flc1125 deleted the otelgin-correct-naming branch February 19, 2025 11:14
@XSAM XSAM added this to the v1.35.0 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants