-
Notifications
You must be signed in to change notification settings - Fork 651
Remove otelhttp/test module #6763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6763 +/- ##
=======================================
- Coverage 75.6% 75.5% -0.2%
=======================================
Files 207 206 -1
Lines 19186 19181 -5
=======================================
- Hits 14512 14484 -28
- Misses 4239 4259 +20
- Partials 435 438 +3 |
dashpole
approved these changes
Feb 12, 2025
dmathieu
approved these changes
Feb 13, 2025
MrAlias
reviewed
Feb 13, 2025
MrAlias
approved these changes
Feb 18, 2025
1 task
This was referenced Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per open-telemetry/opentelemetry-go#6286 (comment)
When module
a
has a dependency is used only in tests then it does not come up as an indirect dependency for modules depending ona
.I think this was not true before and that the Go module graph pruning has been improved at some point.
I think that it means that we can get rid of
test
modules as can use SDK in tests and examples as they do not come up as indirect dependencies ingo.mod
.EDIT: The test modules were introduced when we were supporting Go 1.15. https://github.com/open-telemetry/opentelemetry-go-contrib/blob/fe2fb58536fff0f85173f56a9091bca9380cee3c/instrumentation/net/http/otelhttp/test/go.mod
Go module pruning was works for modules requiring at least Go 1.17. See: https://go.dev/ref/mod#graph-pruning and
https://go.dev/doc/go1.17
I plan to do the same for all test modules in separate PRs.