Skip to content

Remove otelhttp/test module #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 18, 2025
Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented Feb 12, 2025

Per open-telemetry/opentelemetry-go#6286 (comment)

When module a has a dependency is used only in tests then it does not come up as an indirect dependency for modules depending on a.

I think this was not true before and that the Go module graph pruning has been improved at some point.

I think that it means that we can get rid of test modules as can use SDK in tests and examples as they do not come up as indirect dependencies in go.mod.

EDIT: The test modules were introduced when we were supporting Go 1.15. https://github.com/open-telemetry/opentelemetry-go-contrib/blob/fe2fb58536fff0f85173f56a9091bca9380cee3c/instrumentation/net/http/otelhttp/test/go.mod
Go module pruning was works for modules requiring at least Go 1.17. See: https://go.dev/ref/mod#graph-pruning and
https://go.dev/doc/go1.17

I plan to do the same for all test modules in separate PRs.

@github-actions github-actions bot requested review from akats7 and dmathieu February 12, 2025 12:57
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5%. Comparing base (6e7414f) to head (d635839).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6763     +/-   ##
=======================================
- Coverage   75.6%   75.5%   -0.2%     
=======================================
  Files        207     206      -1     
  Lines      19186   19181      -5     
=======================================
- Hits       14512   14484     -28     
- Misses      4239    4259     +20     
- Partials     435     438      +3     

see 4 files with indirect coverage changes

@pellared pellared changed the title [Spike] Remove otelhttp/test module Remove otelhttp/test module Feb 12, 2025
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Feb 12, 2025
@pellared pellared marked this pull request as draft February 12, 2025 13:30
@pellared pellared marked this pull request as ready for review February 12, 2025 13:32
@pellared pellared requested a review from MrAlias February 13, 2025 16:44
@pellared pellared added this to the v1.35.0 milestone Feb 18, 2025
@pellared pellared merged commit 00687a5 into open-telemetry:main Feb 18, 2025
31 checks passed
@pellared pellared deleted the otelhttp-rem-test branch February 18, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants