Skip to content

Remove toolchain statement from otelgin example #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2024
Merged

Remove toolchain statement from otelgin example #6178

merged 2 commits into from
Oct 2, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Oct 2, 2024

Closes #6170.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 2, 2024
@dmathieu dmathieu marked this pull request as ready for review October 2, 2024 07:59
@dmathieu dmathieu requested review from hanyuancheung and a team as code owners October 2, 2024 07:59
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.8%. Comparing base (a54bb0b) to head (379bc46).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6178   +/-   ##
=====================================
  Coverage   66.8%   66.8%           
=====================================
  Files        206     206           
  Lines      13211   13211           
=====================================
+ Hits        8833    8835    +2     
+ Misses      4111    4110    -1     
+ Partials     267     266    -1

see 1 file with indirect coverage changes

@pellared
Copy link
Member

pellared commented Oct 2, 2024

Trivial change. Planning to merge.

@dmathieu dmathieu merged commit 1c8a001 into open-telemetry:main Oct 2, 2024
24 of 25 checks passed
@dmathieu dmathieu deleted the otelginexample-toolchain branch October 2, 2024 09:12
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dmathieu @pellared @MrAlias