Add AWS X-Ray Propagator #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKelvinLo
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Aneurysm9
approved these changes
Nov 21, 2020
jmacd
reviewed
Nov 24, 2020
|
@jmacd Hi Josh, I accidentally merged into our fork. I removed the ECS resource detector parts - could you take a look again? Thanks |
MrAlias
requested changes
Nov 30, 2020
dashpole
reviewed
Nov 30, 2020
* add AWS X-Ray propagator and tests * made naming convention changes to adhere to linter * added comment to interface implementation for clarity * update naming convention and added description for method
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
The methods on the `Float64Gauge`, `Int64Gauge`, `Float64Counter`, `Int64Counter`, `Float64Measure`, and `Int64Measure` `struct`s do not need to mutate the internal state of the `struct` and can therefore be defined with value receivers instead. This aligns closer to the function signatures of each instruments constructor function. Additionally, this change means calls to these methods do not need an allocation to the heap. Resolves #440 Co-authored-by: Rahul Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR adds a propagator for propgating AWS X-Ray headers so that AWS X-Ray is able to receive and read traces from the OpenTelemetry Go SDK.
Short description of the changes
cc: @alolita