Remove semver: prefix from instrumentation version

[9bany]

ref: open-telemetry/opentelemetry-specification#873
issue related: #3681

• Remove semver: prefix
• Deprecate the SemVersion functions.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: 9bany / name: bany (25e7a26, 9dca665)

[codecov]

Codecov Report

Merging #3798 (b0660e3) into main (a08e95c) will increase coverage by 4.3%.
The diff coverage is 30.4%.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #3798     +/-   ##
=======================================
+ Coverage   70.5%   74.8%   +4.3%     
=======================================
  Files        149     154      +5     
  Lines       7133    7198     +65     
=======================================
+ Hits        5030    5388    +358     
+ Misses      1972    1663    -309     
- Partials     131     147     +16     

Impacted Files	Coverage Δ
detectors/aws/ec2/version.go	0.0% <0.0%> (ø)
detectors/aws/ecs/version.go	0.0% <0.0%> (ø)
detectors/aws/eks/version.go	0.0% <0.0%> (ø)
detectors/gcp/version.go	0.0% <0.0%> (ø)
...thub.com/Shopify/sarama/otelsarama/test/version.go	0.0% <0.0%> (ø)
...on/github.com/Shopify/sarama/otelsarama/version.go	60.0% <0.0%> (-40.0%)	⬇️
...github.com/astaxie/beego/otelbeego/test/version.go	0.0% <0.0%> (ø)
...tion/github.com/astaxie/beego/otelbeego/version.go	0.0% <0.0%> (ø)
...github.com/aws/aws-lambda-go/otellambda/version.go	60.0% <0.0%> (-40.0%)	⬇️
...thub.com/aws/aws-sdk-go-v2/otelaws/test/version.go	0.0% <0.0%> (ø)
... and 55 more

... and 6 files with indirect coverage changes

[pellared]

Can we use Version() instead of SemVersion() in places where we initialize instrumentation.Library and deprecate the SemVersion functions?

[pellared]

@9bany Can you sign the CLA?

[9bany]

Can we use Version() instead of SemVersion() in places where we initialize instrumentation.Library and deprecate the SemVersion functions?

@pellared Yeah! we can.
Let me delete SemVersion functions

[pellared]

Can we use Version() instead of SemVersion() in places where we initialize instrumentation.Library and deprecate the SemVersion functions?

@pellared Yeah! we can. Let me delete SemVersion functions

@open-telemetry/go-approvers Are we fine removing SemVersion functions (all modules are v0.*) or do we prefer to deprecate them first?

[MrAlias]

Can we use Version() instead of SemVersion() in places where we initialize instrumentation.Library and deprecate the SemVersion functions?

@pellared Yeah! we can. Let me delete SemVersion functions

@open-telemetry/go-approvers Are we fine removing SemVersion functions (all modules are v0.*) or do we prefer to deprecate them first?

+1 to deprecation

[pellared]

+1 to deprecation

I am also leaning towards deprecation as the function was exported and someone might be using it. We should have the functions marked as deprecated at least for one release before removing them.

[9bany]

I have no idea to fix this error

Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3.1.3/dist/codecov' failed with exit code 255

ref: Details

[pellared]

I have no idea to fix this error

It happens. Do not worry 😉 I will rerun until it passes.

[9bany]

As you can see in this https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/3798?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=open-telemetry
Our testcase cannot cover SemVersion because we removed it from anywhere it was used. Now, how can I fix that ?
@pellared

[MrAlias]

As you can see in this https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/3798?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=open-telemetry Our testcase cannot cover SemVersion because we removed it from anywhere it was used. Now, how can I fix that ? @pellared

Right. That's understood when looking at the coverage 👍