-
Notifications
You must be signed in to change notification settings - Fork 652
Fix rate limiting sampler to drop trace when lower bound is zero #3604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MrAlias
merged 5 commits into
open-telemetry:main
from
vietdoan:vietdoan/jaegerremote_rate_limiting_sampler_zero_lower_bound
Mar 22, 2023
Merged
Fix rate limiting sampler to drop trace when lower bound is zero #3604
MrAlias
merged 5 commits into
open-telemetry:main
from
vietdoan:vietdoan/jaegerremote_rate_limiting_sampler_zero_lower_bound
Mar 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MrAlias
approved these changes
Mar 19, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3604 +/- ##
=====================================
Coverage 70.0% 70.0%
=====================================
Files 147 147
Lines 6956 6960 +4
=====================================
+ Hits 4870 4874 +4
Misses 1961 1961
Partials 125 125
|
Please add a changelog entry for the fix. |
hanyuancheung
approved these changes
Mar 20, 2023
dmathieu
approved these changes
Mar 20, 2023
MrAlias
reviewed
Mar 22, 2023
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Mar 22, 2023
This was referenced Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time we fetch config, a new
rateLimitingSampler
is created and then it always accept a trace even though thelowerbound
is zero. AsguaranteedThroughputProbabilisticSampler
leverages bothprobabilisticSampler
andrateLimitingSampler
, the sampler still sample trace with zero probability as described in #3603