Skip to content

Fix rate limiting sampler to drop trace when lower bound is zero #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vietdoan
Copy link
Contributor

Every time we fetch config, a new rateLimitingSampler is created and then it always accept a trace even though the lowerbound is zero. As guaranteedThroughputProbabilisticSampler leverages both probabilisticSampler and rateLimitingSampler, the sampler still sample trace with zero probability as described in #3603

@vietdoan vietdoan requested a review from a team March 18, 2023 09:27
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #3604 (b95207b) into main (83b942a) will increase coverage by 0.0%.
The diff coverage is 40.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3604   +/-   ##
=====================================
  Coverage   70.0%   70.0%           
=====================================
  Files        147     147           
  Lines       6956    6960    +4     
=====================================
+ Hits        4870    4874    +4     
  Misses      1961    1961           
  Partials     125     125           
Impacted Files Coverage Δ
...mplers/jaegerremote/internal/utils/rate_limiter.go 93.3% <40.0%> (-6.7%) ⬇️

... and 1 file with indirect coverage changes

@MrAlias
Copy link
Contributor

MrAlias commented Mar 19, 2023

Please add a changelog entry for the fix.

@vietdoan vietdoan requested a review from MrAlias March 19, 2023 17:20
Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants