-
Notifications
You must be signed in to change notification settings - Fork 651
otelaws: adding dynamodb attributes #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aneurysm9
merged 16 commits into
open-telemetry:main
from
jennynilsen:dynamodb-attributes
Feb 25, 2022
Merged
otelaws: adding dynamodb attributes #1582
Aneurysm9
merged 16 commits into
open-telemetry:main
from
jennynilsen:dynamodb-attributes
Feb 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
reviewed
Jan 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I think I like the approach overall. My comments are mostly stylistic/structural.
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/test/dynamodbattributes_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/go.mod
Outdated
Show resolved
Hide resolved
Aneurysm9
reviewed
Jan 14, 2022
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/test/dynamodbattributes_test.go
Outdated
Show resolved
Hide resolved
Aneurysm9
reviewed
Jan 17, 2022
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/config.go
Outdated
Show resolved
Hide resolved
MrAlias
reviewed
Jan 24, 2022
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes_test.go
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes_test.go
Show resolved
Hide resolved
Co-authored-by: Tyler Yahn <[email protected]>
This reverts commit 05c3847.
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Feb 4, 2022
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/config.go
Outdated
Show resolved
Hide resolved
Aneurysm9
approved these changes
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #1582 +/- ##
=======================================
+ Coverage 69.6% 70.3% +0.7%
=======================================
Files 127 128 +1
Lines 5391 5537 +146
=======================================
+ Hits 3755 3898 +143
- Misses 1498 1500 +2
- Partials 138 139 +1
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When appending the middlewares to a dynamodb client, no dynamodb attributes are added to the spans.
This PR :
adds dynamodb attributes that correspond to the dynamodb operation to the spans
allows someone to provide their own function to set custom attributes
adds a way to determine the attributes to set based on service automatically