Fix bug related to event timestamp format. #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exporter assumes that we are using `opentelemetry:timestamp/0`, which returns a timestamp in the erlang native format. This commit cleans up use of `erlang:system_time/1`.
derekkraan
force-pushed
the
use_opentelemetry_timestamp
branch
from
903fe6e to
eb4bc7c
Compare
derekkraan
changed the title
opentelemetry:timestamp() function, which returns a timestamp in the native format. This commit cleans up use of erlang:system_time/1.
Codecov Report
@@ Coverage Diff @@
## main #354 +/- ##
=======================================
Coverage 33.59% 33.59%
=======================================
Files 56 56
Lines 4560 4560
=======================================
Hits 1532 1532
Misses 3028 3028
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Agh, thanks! I vaguely recall meaning to look into the use of timestamps and why there were multiple forms but can't remember why... this is definitely the right fix. |
tsloughter
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter assumes that we are using
opentelemetry:timestamp/0, which returns a timestamp in the erlang native format. This commit cleans up use oferlang:system_time/1.