Skip to content

Fix exporting spans with links #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Conversation

indrekj
Copy link
Contributor

@indrekj indrekj commented Jan 3, 2022

This fixes exporting spans that include links. Previously these resulted
in this error:

exception error: bad map: {attributes,128,infinity,0,#{}}

The test is not the most sophisticated one, but it at least catches this
particular error.

This fixes exporting spans that include links. Previously these resulted
in this error:
```
exception error: bad map: {attributes,128,infinity,0,#{}}
```

The test is not the most sophisticated one, but it at least catches this
particular error.
@indrekj indrekj requested a review from a team January 3, 2022 17:35
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #340 (5349796) into main (724460c) will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   32.55%   33.27%   +0.72%     
==========================================
  Files          56       56              
  Lines        4559     4559              
==========================================
+ Hits         1484     1517      +33     
+ Misses       3075     3042      -33     
Flag Coverage Δ
api 67.28% <ø> (ø)
elixir 16.44% <ø> (ø)
erlang 33.21% <ø> (+0.73%) ⬆️
exporter 21.33% <ø> (+1.35%) ⬆️
sdk 77.13% <ø> (+0.25%) ⬆️
zipkin 2.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntelemetry_exporter/src/opentelemetry_exporter.erl 73.45% <ø> (+0.61%) ⬆️
...er/src/opentelemetry_exporter_trace_service_pb.erl 17.35% <0.00%> (+1.41%) ⬆️
apps/opentelemetry/src/otel_links.erl 73.33% <0.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724460c...5349796. Read the comment docs.

@tsloughter tsloughter merged commit a22fb0e into open-telemetry:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants