Skip to content

exporter: update trace protos to v0.11.0 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2021

Conversation

tsloughter
Copy link
Member

No description provided.

@tsloughter tsloughter requested a review from a team November 19, 2021 22:59
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #314 (09dafec) into main (3aeec46) will increase coverage by 0.71%.
The diff coverage is 13.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   37.86%   38.57%   +0.71%     
==========================================
  Files          50       50              
  Lines        3333     3463     +130     
==========================================
+ Hits         1262     1336      +74     
- Misses       2071     2127      +56     
Flag Coverage Δ
api 64.82% <ø> (ø)
elixir 14.73% <ø> (ø)
erlang 38.60% <13.45%> (+0.72%) ⬆️
exporter 21.77% <13.45%> (+2.16%) ⬆️
sdk 76.33% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/src/opentelemetry_exporter_trace_service_pb.erl 18.01% <5.58%> (+2.27%) ⬆️
...ntelemetry_exporter/src/opentelemetry_exporter.erl 74.34% <73.07%> (-0.13%) ⬇️
apps/opentelemetry/src/otel_resource_detector.erl 91.89% <0.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aeec46...09dafec. Read the comment docs.

@tsloughter tsloughter force-pushed the trace-protos-0.11.0 branch 2 times, most recently from 833d3d0 to 8ba78a5 Compare November 19, 2021 23:18
@tsloughter
Copy link
Member Author

CI is failing because the committed module generated by gpb was generated on OTP-24 and won't compile on earlier versions. I opened an issue on gpb about a possible fix but guess I'll also just build OTP-23 locally and re-generate the module.

@tsloughter tsloughter merged commit bad9d42 into open-telemetry:main Nov 26, 2021
@tsloughter tsloughter deleted the trace-protos-0.11.0 branch November 26, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants