Skip to content

use get_application_tracer in Elixir macros #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

tsloughter
Copy link
Member

The Erlang macros already properly use get_application_tracer.
The reason to use get_application_tracer is the macros lookup
the tracer for the particular application by module name.

The Erlang macros already properly use get_application_tracer.
The reason to use get_application_tracer is the macros lookup
the tracer for the particular application by module name.
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #303 (f68e83a) into main (aa1ed7b) will not change coverage.
The diff coverage is n/a.

❗ Current head f68e83a differs from pull request most recent head 21bec97. Consider uploading reports for the commit 21bec97 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   37.35%   37.35%           
=======================================
  Files          46       46           
  Lines        3266     3266           
=======================================
  Hits         1220     1220           
  Misses       2046     2046           
Flag Coverage Δ
api 65.14% <ø> (ø)
elixir 14.59% <ø> (+0.18%) ⬆️
erlang 37.35% <ø> (ø)
exporter 19.75% <ø> (ø)
sdk 76.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pps/opentelemetry_api/lib/open_telemetry/tracer.ex 37.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1ed7b...21bec97. Read the comment docs.

@tsloughter
Copy link
Member Author

We should maybe just get rid of the separation between tracers registered automatically for each application and those registered by the user, and then there would be only one "get tracer" function available anyway

@indrekj
Copy link
Contributor

indrekj commented Nov 1, 2021

We should maybe just get rid of the separation between tracers registered automatically for each application and those registered by the user, and then there would be only one "get tracer" function available anyway

That would simplify things. Currently the tracers & application tracers part is quite confusing, at least to me.

Copy link
Contributor

@indrekj indrekj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me, but I'll try it out in real code tomorrow

@tsloughter
Copy link
Member Author

Agree it will probably confuse people.

Likely will merge this to get erlang and elixir to at least match asap and then have a PR for just getting rid of the separation.

@tsloughter tsloughter merged commit c47a3f2 into open-telemetry:main Nov 1, 2021
@tsloughter tsloughter deleted the ex-app-tracer branch November 1, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants