Skip to content

add get_description to sampler and support for updating tracestate in sampler #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

tsloughter
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #129 into master will increase coverage by 0.20%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   31.83%   32.03%   +0.20%     
==========================================
  Files          63       63              
  Lines        2972     2981       +9     
==========================================
+ Hits          946      955       +9     
  Misses       2026     2026              
Flag Coverage Δ
#api 46.44% <ø> (ø)
#elixir 16.24% <ø> (ø)
#erlang 31.87% <88.00%> (+0.21%) ⬆️
#exporter 17.05% <ø> (ø)
#sdk 64.37% <88.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry/src/otel_span_utils.erl 87.50% <60.00%> (ø)
apps/opentelemetry/src/otel_sampler.erl 84.61% <95.00%> (+1.28%) ⬆️
apps/opentelemetry/src/otel_batch_processor.erl 73.56% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cba94...799d241. Read the comment docs.

@tsloughter tsloughter merged commit 6da493f into open-telemetry:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants