[ResourceDetectors.AWS] Implement support for some cloud.resource_id attribute in AWS ECS detector #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attribute in AWS ECS detector
utpilla
added
the
comp:resources.aws
Co-authored-by: Vishwesh Bankwar <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@ppittle FYA.. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
ppittle
approved these changes
Mar 9, 2024
|
Looks good to me. @mmanciop - thanks for adding .net to your list of implementations! |
Kielek
approved these changes
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1576 +/- ##
==========================================
+ Coverage 73.91% 80.65% +6.73%
==========================================
Files 267 114 -153
Lines 9615 3081 -6534
==========================================
- Hits 7107 2485 -4622
+ Misses 2508 596 -1912
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implement support in the AWS ECS detector
cloud.resource_idset to the ECS Container ARN, see open-telemetry/semantic-conventions#677.CHANGELOG.mdupdated for non-trivial changes