-
Notifications
You must be signed in to change notification settings - Fork 483
Add opentelemetry.io docs #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #636 +/- ##
==========================================
- Coverage 94.49% 94.47% -0.02%
==========================================
Files 197 197
Lines 9130 9130
==========================================
- Hits 8627 8626 -1
- Misses 503 504 +1
|
|
||
| Tracing | Metrics | Logging | | ||
| ------- | ------- | ------- | | ||
| Pre-Alpha | Pre-Alpha | Not Yet Implemented | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - we do have logging api/sdk pre-alpha release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I think Metrics should be "Not Yet Implemented".
## Further Reading | ||
|
||
- [OpenTelemetry for C++ on GitHub](https://github.com/open-telemetry/opentelemetry-cpp) | ||
- [Examples](https://github.com/open-telemetry/opentelemetry-cpp/tree/main/examples) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@austinlparker would it be okay to put the @open-telemetry/cpp-maintainers as the "CODEOWNER" of this folder https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/cpp? In this way we don't have to duplicate the contents in this repo. I can update the OTel C++ release process and put something like "for each release, update the opentelemetry.io docs". |
I've submitted a PR open-telemetry/opentelemetry.io#505. Once it is merged, I'll update the release process doc https://github.com/open-telemetry/opentelemetry-cpp/blob/main/RELEASING.md then we can close this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish to explore if we could avoid duplicating docs. Mirroring the docs will create problem since we don't have the same CI rule between the OTel C++ and opentelemetry.io repo.
I'm trying to avoid mirroring by making this be the authoritative source - my goal is to have a github action that will push these changes to the website each release. |
Unfortunately this is one of those things where everyone wants to do this slightly differently :| |
This would be great! |
@austinlparker I'm closing this PR as a result of #639. |
Per open-telemetry/opentelemetry.io#472, we're mirroring the docs content on the website to each SIG. When a release occurs and these docs are updated, please make an issue or PR mirroring them to their appropriate location in the website repo (https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/cpp).