Added default functions for configauth #9850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @TylerHelmuth, can you please approve again? Hello @djaglowski can I please get a review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9850 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 358 358
Lines 16543 16545 +2
=======================================
+ Hits 15171 15173 +2
Misses 1045 1045
Partials 327 327 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
approved these changes
Mar 26, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hello @TylerHelmuth is there anything I need to do so this PR can get merged |
TylerHelmuth
added
ready-to-merge
codeboten
reviewed
Apr 17, 2024
codeboten
approved these changes
Apr 17, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added NewDefault methods for structs in
configauthpackageLink to tracking Issue:
Closes #9821
Testing: Tests were added for the NewDefault functions