[client] add new module go.opentelemetry.io/collector/client
#9805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
client_module
branch
2 times, most recently
from
08d91aa to
0f67eaa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9805 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 403 403
Lines 18739 18739
=======================================
Hits 17313 17313
Misses 1066 1066
Partials 360 360 ☔ View full report in Codecov by Sentry. |
|
Please consider a big refactor (including renaming probably) for this package before marking stable. |
|
Thanks Bogdan, captured this feedback in #9818 |
atoulme
commented
Mar 25, 2024
atoulme
commented
Mar 25, 2024
atoulme
commented
Mar 25, 2024
atoulme
commented
Mar 25, 2024
atoulme
commented
Mar 25, 2024
atoulme
commented
Mar 25, 2024
atoulme
commented
Mar 25, 2024
atoulme
commented
Mar 25, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
andrzej-stencel
approved these changes
Apr 10, 2024
atoulme
force-pushed
the
client_module
branch
6 times, most recently
from
aa73da9 to
fc5cd5f
Compare
|
There might be a few other ways to go about this ; closing for now this PR and let's maybe work on a refactoring approach. |
atoulme
force-pushed
the
client_module
branch
5 times, most recently
from
f7630b9 to
c971a37
Compare
jpkrohling
approved these changes
Jul 19, 2024
atoulme
changed the title
go.opentelemetry.io/collector/clientgo.opentelemetry.io/collector/conn
atoulme
changed the title
go.opentelemetry.io/collector/conngo.opentelemetry.io/collector/client
mx-psi
approved these changes
Jul 22, 2024
TylerHelmuth
approved these changes
Jul 22, 2024
mx-psi
added
the
release:blocker
|
@atoulme can you fix the merge conflict? @open-telemetry/collector-approvers I will merge this on Friday if nobody blocks before then |
songy23
reviewed
Jul 23, 2024
songy23
approved these changes
Jul 23, 2024
codeboten
reviewed
Jul 23, 2024
Co-authored-by: Yang Song <[email protected]>
atoulme
commented
Jul 23, 2024
codeboten
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Create a new go module
go.opentelemetry.io/collector/clientLink to tracking Issue:
Fixes #9804