-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[mdatagen] update crosslink to avoid replace statements #9310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdatagen] update crosslink to avoid replace statements #9310
Conversation
This fixes open-telemetry#9281 Signed-off-by: Alex Boten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with that fix, however, it means mdatagen will continue to import packages from this repository. Will this matter to mdatagen? Will it be updated separately?
With this change, mdatagen will only used released versions of the packages from this repo. I don't know what a workaround this is if we want mdatagen to be installed via |
Signed-off-by: Alex Boten <[email protected]>
@atoulme i suppose we could still use unreleased versions of the packages as long as they're explicitly stated in the go.mod file, without replace statements 🤷🏻 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9310 +/- ##
==========================================
- Coverage 90.35% 90.34% -0.01%
==========================================
Files 340 340
Lines 17968 17987 +19
==========================================
+ Hits 16235 16251 +16
- Misses 1410 1412 +2
- Partials 323 324 +1 ☔ View full report in Codecov by Sentry. |
If we make a change to mdatagen, like say adding a new field to the readme headers, does this change prevent us from testing that change on one of core's components until after the release? |
It does not. Its just that if a change happens in one of the core components, it wont be automatically tested by mdatagen |
…ry#9310) Fixes open-telemetry#9281 --------- Signed-off-by: Alex Boten <[email protected]>
Fixes #9281