Skip to content

Deprecate BatcherConfig and WithBatcher in favor of the new QueueBatchConfig #12748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bogdandrutu
Copy link
Member

No description provided.

The config for batcher is moving to queue configuration.

Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
@bogdandrutu bogdandrutu requested review from a team and dmitryax as code owners March 27, 2025 03:16
@bogdandrutu bogdandrutu force-pushed the codeboten/deprecate-batcher-config branch 2 times, most recently from 3a14a05 to 616bd93 Compare March 27, 2025 03:18
@bogdandrutu bogdandrutu changed the title Codeboten/deprecate batcher config Deprecate BatcherConfig and WithBatcher in favor of the new QueueBatchConfig Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.54%. Comparing base (f09817e) to head (2cd780f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/otlpexporter/config.go 20.00% 6 Missing and 2 partials ⚠️
exporter/exporterhelper/internal/queue_sender.go 0.00% 2 Missing and 1 partial ⚠️
exporter/otlpexporter/otlp.go 0.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (30.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12748      +/-   ##
==========================================
- Coverage   91.58%   91.54%   -0.05%     
==========================================
  Files         479      479              
  Lines       26468    26478      +10     
==========================================
- Hits        24242    24239       -3     
- Misses       1756     1765       +9     
- Partials      470      474       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu force-pushed the codeboten/deprecate-batcher-config branch from 616bd93 to 2cd780f Compare March 27, 2025 03:27
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 27, 2025
Merged via the queue into open-telemetry:main with commit 40cb530 Mar 27, 2025
52 of 56 checks passed
@bogdandrutu bogdandrutu deleted the codeboten/deprecate-batcher-config branch March 27, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants