-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Avoid using go embedded messages in Config #12718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using go embedded messages in Config #12718
Conversation
bdde9b4
to
cf1a228
Compare
cf1a228
to
af2f840
Compare
af2f840
to
3ece557
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
3ece557
to
61893b4
Compare
I guess, we should add this as a guideline in https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/coding-guidelines.md#configuration-structs |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (93.75%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12718 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 480 480
Lines 26456 26456
=======================================
Hits 24218 24218
Misses 1772 1772
Partials 466 466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
58370e5
- exporterhelper.QueueConfig -> exporterhelper.QueueBatchConfig - Update exporter/alertmanager tests - Address open-telemetry/opentelemetry-collector#12718
This PR:
QueueConfig
is under "seding_queue".