-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Stabilize extensionauth #12675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize extensionauth #12675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12675 +/- ##
==========================================
- Coverage 91.66% 91.50% -0.16%
==========================================
Files 479 480 +1
Lines 26355 26464 +109
==========================================
+ Hits 24159 24217 +58
- Misses 1733 1778 +45
- Partials 463 469 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cc @open-telemetry/collector-approvers I intend to merge this next Wednesday if I get enough approvals by then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@mx-psi can you wait a bit on this. I want to do a small draft to show something. I want to see a bit of progress on @jmacd's PR related to limiter. I am not sure if EDIT: Here is what I meant #12702, everything looks nice except the "hacky" way of dealing with the query params. |
@bogdandrutu I can remove the |
We discussed this on the stability meeting from Monday March 24th and agreed to first stabilize |
7199d3f
Description
Marks extensionauth as 1.x
Link to tracking issue
Fixes #11006