Skip to content

Stabilize extensionauth #12675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 19, 2025

Description

Marks extensionauth as 1.x

Link to tracking issue

Fixes #11006

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (69908f4) to head (78b2aad).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12675      +/-   ##
==========================================
- Coverage   91.66%   91.50%   -0.16%     
==========================================
  Files         479      480       +1     
  Lines       26355    26464     +109     
==========================================
+ Hits        24159    24217      +58     
- Misses       1733     1778      +45     
- Partials      463      469       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi marked this pull request as ready for review March 19, 2025 15:01
@mx-psi mx-psi requested a review from a team as a code owner March 19, 2025 15:01
@mx-psi mx-psi requested a review from jade-guiton-dd March 19, 2025 15:01
@mx-psi
Copy link
Member Author

mx-psi commented Mar 19, 2025

cc @open-telemetry/collector-approvers

I intend to merge this next Wednesday if I get enough approvals by then

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bogdandrutu
Copy link
Member

bogdandrutu commented Mar 22, 2025

@mx-psi can you wait a bit on this. I want to do a small draft to show something. I want to see a bit of progress on @jmacd's PR related to limiter.

I am not sure if func (a Authentication) GetHTTPClientAuthenticator should return the extensionauth.HTTPClient or directly resolve http.RoundTripper. The advantage of the later is that we can hide to the consumers of the Authentication config multiple possible implementations, for example in case of #12700 we can return the grpc.DialOption so that we can support the Interceptors version, or the StatsHandler version or the Limiter.

EDIT: Here is what I meant #12702, everything looks nice except the "hacky" way of dealing with the query params.

@mx-psi
Copy link
Member Author

mx-psi commented Mar 24, 2025

@bogdandrutu I can remove the configauth part of this PR, and only stabilize extensionauth. Would that work for you?

@mx-psi
Copy link
Member Author

mx-psi commented Mar 26, 2025

We discussed this on the stability meeting from Monday March 24th and agreed to first stabilize extensionauth and leave configauth for after we have decided on #12702. Merging this after removing the configauth bits!

@mx-psi mx-psi changed the title Stabilize configauth and extensionauth Stabilize extensionauth Mar 26, 2025
@mx-psi mx-psi enabled auto-merge March 26, 2025 10:23
@mx-psi mx-psi added this pull request to the merge queue Mar 26, 2025
Merged via the queue into open-telemetry:main with commit 7199d3f Mar 26, 2025
53 of 56 checks passed
@mx-psi mx-psi deleted the mx-psi/extensionauth-configauth branch March 26, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize module extension/extensionauth
7 participants