-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[extensionauth,configauth] Remove deprecated symbols #12672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mx-psi
merged 2 commits into
open-telemetry:main
from
mx-psi:mx-psi/remove-deprecated-stuff
Mar 19, 2025
Merged
[extensionauth,configauth] Remove deprecated symbols #12672
mx-psi
merged 2 commits into
open-telemetry:main
from
mx-psi:mx-psi/remove-deprecated-stuff
Mar 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ee4c42
to
4a22906
Compare
4a22906
to
d0a0b36
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12672 +/- ##
==========================================
+ Coverage 91.63% 91.66% +0.02%
==========================================
Files 479 479
Lines 26423 26355 -68
==========================================
- Hits 24214 24159 -55
+ Misses 1749 1733 -16
- Partials 460 463 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This breaks some contrib tests. open-telemetry/opentelemetry-collector-contrib/pull/38796 fixes that |
songy23
approved these changes
Mar 19, 2025
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 19, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description I intend to make `extensionauth.Server` independent of `extension.Extension` with open-telemetry/opentelemetry-collector/pull/12672. This means some changes in tests and such to make sure that we cast to the right interface when calling each method. This should have no visible impact to end users.
Merged
via the queue into
open-telemetry:main
with commit Mar 19, 2025
41a9ea7
54 of 55 checks passed
lightme16
pushed a commit
to lightme16/opentelemetry-collector-contrib
that referenced
this pull request
Mar 19, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description I intend to make `extensionauth.Server` independent of `extension.Extension` with open-telemetry/opentelemetry-collector/pull/12672. This means some changes in tests and such to make sure that we cast to the right interface when calling each method. This should have no visible impact to end users.
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description I intend to make `extensionauth.Server` independent of `extension.Extension` with open-telemetry/opentelemetry-collector/pull/12672. This means some changes in tests and such to make sure that we cast to the right interface when calling each method. This should have no visible impact to end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes deprecated symbols from
extensionauth
andconfigauth
modulesLink to tracking issue
Follows #12574