Skip to content

[extensionauth,configauth] Remove deprecated symbols #12672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 19, 2025

Description

Removes deprecated symbols from extensionauth and configauth modules

Link to tracking issue

Follows #12574

@mx-psi mx-psi force-pushed the mx-psi/remove-deprecated-stuff branch from 0ee4c42 to 4a22906 Compare March 19, 2025 10:36
@mx-psi mx-psi force-pushed the mx-psi/remove-deprecated-stuff branch from 4a22906 to d0a0b36 Compare March 19, 2025 10:47
@mx-psi mx-psi marked this pull request as ready for review March 19, 2025 10:50
@mx-psi mx-psi requested a review from a team as a code owner March 19, 2025 10:50
@mx-psi mx-psi requested a review from evan-bradley March 19, 2025 10:50
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (d9c9cda) to head (622a6ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12672      +/-   ##
==========================================
+ Coverage   91.63%   91.66%   +0.02%     
==========================================
  Files         479      479              
  Lines       26423    26355      -68     
==========================================
- Hits        24214    24159      -55     
+ Misses       1749     1733      -16     
- Partials      460      463       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi
Copy link
Member Author

mx-psi commented Mar 19, 2025

This breaks some contrib tests. open-telemetry/opentelemetry-collector-contrib/pull/38796 fixes that

mx-psi added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Mar 19, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

I intend to make `extensionauth.Server` independent of
`extension.Extension` with
open-telemetry/opentelemetry-collector/pull/12672. This means some
changes in tests and such to make sure that we cast to the right
interface when calling each method. This should have no visible impact
to end users.
@mx-psi mx-psi added this pull request to the merge queue Mar 19, 2025
Merged via the queue into open-telemetry:main with commit 41a9ea7 Mar 19, 2025
54 of 55 checks passed
@mx-psi mx-psi deleted the mx-psi/remove-deprecated-stuff branch March 19, 2025 15:08
lightme16 pushed a commit to lightme16/opentelemetry-collector-contrib that referenced this pull request Mar 19, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

I intend to make `extensionauth.Server` independent of
`extension.Extension` with
open-telemetry/opentelemetry-collector/pull/12672. This means some
changes in tests and such to make sure that we cast to the right
interface when calling each method. This should have no visible impact
to end users.
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

I intend to make `extensionauth.Server` independent of
`extension.Extension` with
open-telemetry/opentelemetry-collector/pull/12672. This means some
changes in tests and such to make sure that we cast to the right
interface when calling each method. This should have no visible impact
to end users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants