[confighttp, configgrpc] Remove experimental note on IncludeMetadata #10685
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10685 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 403 403
Lines 18729 18729
=======================================
Hits 17303 17303
Misses 1066 1066
Partials 360 360 ☔ View full report in Codecov by Sentry. |
|
Fixes #9642 as well. |
|
Added this
to the PR description |
There was a problem hiding this comment.
This is related to client, so I said before that we should probably want to stabilize that first (more discussion here #9381 (comment)).
Looking at client, I don't see any major changes waiting, so I am in favor of merging this with the understanding that we need to make client 1.0 to make configgrpc/confighttp 1.0
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [user, api] |
There was a problem hiding this comment.
I don't believe this should be in the user-facing changelog
There was a problem hiding this comment.
Woops. I'll open a new PR to fix that.
Description
Remove the experimental comment on
IncludeMetadatain confighttp and configgrpcLink to tracking issue
Fixes #9381, Fixes #9642