Skip to content

Introduce eBPF Profiler distribution #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Apr 28, 2025
Merged

Introduce eBPF Profiler distribution #908

merged 36 commits into from
Apr 28, 2025

Conversation

dmathieu
Copy link
Member

This introduces a new distribution that is meant to run the eBPF Profiler as an agent.

@dmathieu dmathieu force-pushed the otelcol-ebpf-profiler branch from 4f096d8 to 2c4186a Compare April 10, 2025 12:59
@dmathieu dmathieu force-pushed the otelcol-ebpf-profiler branch from 9158183 to c23f474 Compare April 10, 2025 13:19
@dmathieu dmathieu force-pushed the otelcol-ebpf-profiler branch from 41ce082 to 0440c63 Compare April 10, 2025 16:06
@dmathieu dmathieu force-pushed the otelcol-ebpf-profiler branch 2 times, most recently from c387647 to ecac474 Compare April 10, 2025 16:33
@dmathieu dmathieu marked this pull request as ready for review April 10, 2025 16:34
@dmathieu dmathieu requested a review from a team as a code owner April 10, 2025 16:34
@dmathieu
Copy link
Member Author

dmathieu commented Apr 10, 2025 •
edited
Loading

cc @open-telemetry/ebpf-profiler-approvers

christos68k
christos68k approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@christos68k christos68k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@dmathieu dmathieu mentioned this pull request Apr 22, 2025
Merged
mx-psi
mx-psi approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing missing is documenting what glibc versions this works with, otherwise it's good to go from my side

@mx-psi mx-psi requested review from TylerHelmuth and mowies April 22, 2025 14:57
@dmathieu
Copy link
Member Author

Only thing missing is documenting what glibc versions this works with, otherwise it's good to go from my side

It doesn't look like the ebpf-profiler documents that itself, so I'm not really sure how to do document that here.

@mx-psi
Copy link
Member

mx-psi commented Apr 23, 2025

Only thing missing is documenting what glibc versions this works with, otherwise it's good to go from my side

It doesn't look like the ebpf-profiler documents that itself, so I'm not really sure how to do document that here.

The glibc version in the 24.04 runner would be 2.39:

❯ docker run --rm -it ubuntu:24.04 ldd --version
ldd (Ubuntu GLIBC 2.39-0ubuntu8.4) 2.39
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

I think that's the minimum version we can guarantee

andrzej-stencel
andrzej-stencel approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dmathieu, looks good from my side.

@dmathieu
Copy link
Member Author

I've added a mention of the current glibc version.

@mx-psi mx-psi mentioned this pull request Apr 23, 2025
Open
@mx-psi
Copy link
Member

mx-psi commented Apr 23, 2025

cc @open-telemetry/collector-contrib-maintainers This adds a new distribution for profiling. It does not add it to the release process yet (no artifact will be available for end-users yet). Instead, it only tests that the distribution can be built. Since this does not have end-user impact, I think we can merge this PR by EOW unless there are blocking comments

@mx-psi mx-psi added this pull request to the merge queue Apr 28, 2025
Merged via the queue into open-telemetry:main with commit 86268e7 Apr 28, 2025
72 checks passed
@dmathieu dmathieu deleted the otelcol-ebpf-profiler branch April 28, 2025 11:57
songy23
songy23 reviewed Apr 28, 2025
View reviewed changes
distributions/otelcol-ebpf-profiler/manifest.yaml
Comment on lines +9 to +20
- gomod: go.opentelemetry.io/collector/exporter/debugexporter v0.123.0
- gomod: go.opentelemetry.io/collector/exporter/nopexporter v0.123.0
- gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.123.0
- gomod: go.opentelemetry.io/collector/exporter/otlphttpexporter v0.123.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.123.0

processors:
- gomod: go.opentelemetry.io/collector/processor/batchprocessor v0.123.0
- gomod: go.opentelemetry.io/collector/processor/memorylimiterprocessor v0.123.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/k8sattributesprocessor v0.123.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.123.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.123.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI These versions are not up-to-date and are not auto-updated by the releaser aa933b1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this is strange. bump-versions.sh has this manifest configured, and everything in collector-contrib should be upgraded from there.

@florianl florianl mentioned this pull request Apr 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@songy23 songy23 songy23 approved these changes

@florianl florianl florianl approved these changes

@rockdaboot rockdaboot rockdaboot approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@christos68k christos68k christos68k approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

@mowies mowies Awaiting requested review from mowies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dmathieu @christos68k @mx-psi @rockdaboot @florianl @mowies @songy23 @TylerHelmuth @andrzej-stencel