feat: config reload #887
Merged
feat: config reload #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, the ACL request is currently stuck with my supervisor, they will take care of this until end of the week, hopefully. |
|
Hey @crobert-1 , the acl is now approved, should I rebase and force push or do you squash merge? |
tim-goto
force-pushed
the
feature/tharing/config-reload
branch
from
0ca434e to
365dd18
Compare
mowies
reviewed
Mar 25, 2025
|
Also, please provide a changelog entry. |
tim-goto
force-pushed
the
feature/tharing/config-reload
branch
from
365dd18 to
c6526e6
Compare
|
Hey, thanks for the feedback, please let me know if it looks good now. It would also be great if the |
mowies
reviewed
Mar 25, 2025
tim-goto
force-pushed
the
feature/tharing/config-reload
branch
from
c6526e6 to
13c7101
Compare
mowies
approved these changes
Mar 26, 2025
|
Do I need to rebase and force push? |
|
No, it's fine to just press the update branch button once in a while, but generally, the maintainer merging the change will do that once more anyways |
|
Hey @crobert-1 if you have time to review I would greatly appreciate that, thanks! |
crobert-1
approved these changes
Apr 9, 2025
|
closes #748 since it's a duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add config reload signal to service definition
closes #748