[cmd/opampsupervisor] Validate that the HUP config reload cannot be used on Windows #41077
+59
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Camata <[email protected]>
douglascamata
requested review from
evan-bradley,
atoulme and
a team
as code owners
Signed-off-by: Douglas Camata <[email protected]>
|
Would love if someone with enough permissions could add the |
evan-bradley
reviewed
Jul 3, 2025
evan-bradley
added
the
Skip Changelog
Signed-off-by: Douglas Camata <[email protected]>
Should make it more elegant to ensure we skip the test for Windows where the HUP reload setting cannot be turned on. Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Douglas Camata <[email protected]>
The case where HUP reload is true is already tested separately. Signed-off-by: Douglas Camata <[email protected]>
evan-bradley
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes in this PR add a validation in the Supervisor's agent configuration that prevents the usage of the SIGHUP configuration reload feature in Windows, as this OS doesn't support such signal.
This PR is a follow up to #40522. Thank you @nenadnoveljic for point it out and notifying us of the Windows build failure.
Testing
Automated test added.