Skip to content

[cmd/opampsupervisor] Add support for optional agent SIGHUP config reload #40522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6fc9d18
[supervisor] Add support for optional agent SIGHUP config reload
douglascamata Jun 6, 2025
abe8566
Enable supervisor template configs to use agent hup restart
douglascamata Jun 6, 2025
e169c76
Run relevant tests agent hup restart besides normal restart
douglascamata Jun 6, 2025
41eb6aa
Fail hup restart is didn't get health from agent
douglascamata Jun 6, 2025
413842e
Add changelog entry
douglascamata Jun 6, 2025
ac5b900
Make linter happy
douglascamata Jun 6, 2025
2534261
Merge branch 'main' into supervisor-hup-collector
douglascamata Jun 11, 2025
d1f9307
Put back e2e go build flag
douglascamata Jun 11, 2025
4dfdbae
Remove unused fields in the `Supervisor` type
douglascamata Jun 26, 2025
d3bf969
Address PR review comments
douglascamata Jun 26, 2025
7181c06
Improve names (hup restart -> hup reload)
douglascamata Jun 26, 2025
5a82591
Protect access to `agentStartedChan` when closing it
douglascamata Jun 26, 2025
098dc4c
Fix Supervisor config generation for tests
douglascamata Jun 27, 2025
6887fdc
Fix e2e test
douglascamata Jun 27, 2025
85cf701
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
douglascamata Jun 27, 2025
84d4c19
Put back `go:build` tag in supervisor e2e test
douglascamata Jun 27, 2025
21cab60
Fix and rename `Supervisor.waitForAgentStart`
douglascamata Jun 27, 2025
601e2f6
Simplify approach for HUP reload implementation
douglascamata Jul 1, 2025
e72d662
Improve comments
douglascamata Jul 1, 2025
6e2ebf7
Remove unnecessary for loop when selecting on channels
douglascamata Jul 1, 2025
c1dbc6e
Fix typo to make linter happy
douglascamata Jul 1, 2025
b291949
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
douglascamata Jul 1, 2025
c130bc8
Passing all e2e tests
douglascamata Jul 1, 2025
9dc39c1
Delegate agent start only to `Supervisor.startAgent()`
douglascamata Jul 2, 2025
52644bc
Ensure HUP e2e tests get the HUP reload config enabled
douglascamata Jul 2, 2025
8a160ae
Remove commented code that got in by accident
douglascamata Jul 2, 2025
abebd1f
Move back nil health assignment to the top of new config handling
douglascamata Jul 2, 2025
2ac33cd
Update cmd/opampsupervisor/supervisor/supervisor.go
evan-bradley Jul 2, 2025
9397d52
Merge branch 'main' into supervisor-hup-collector
evan-bradley Jul 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .chloggen/supervisor-hup-reload.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: cmd/opampsupervisor

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Allow the Supervisor send a SIGHUP signal to the agent to reload its configuration.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [40410]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: This behavior is disabled by default. To enable it, set the `agent::enable_hup_reload` flag to `true` in the supervisor configuration.

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
Loading