[receiver/cloudflare] Support map fields #40349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Nyström <[email protected]>
Signed-off-by: Patrik Nyström <[email protected]>
Signed-off-by: Patrik Nyström <[email protected]>
Signed-off-by: Patrik Nyström <[email protected]>
Signed-off-by: Patrik Nyström <[email protected]>
dehaansa
changed the title
atoulme
reviewed
May 28, 2025
Signed-off-by: Patrik Nyström <[email protected]>
Signed-off-by: Patrik Nyström <[email protected]>
dehaansa
reviewed
May 28, 2025
receiver/cloudflarereceiver/logs.go
Outdated
| case map[string]any: | ||
| // Recursively flatten nested maps | ||
| nested := flattenMap(val, newKey+separator, separator) | ||
| maps.Copy(result, nested) |
There was a problem hiding this comment.
Rather than requiring a Copy, can we have the output map be a function parameter?
Signed-off-by: Patrik Nyström <[email protected]>
Signed-off-by: Patrik Nyström <[email protected]>
dehaansa
approved these changes
Jun 3, 2025
dehaansa
added
ready to merge
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
#### Description Enable the receiver to consume fields from Cloudflare containing a map Also added a configuration option for setting a separator where `.` is default #### Link to tracking issue Fixes open-telemetry#40318 #### Testing Unit tests added --------- Signed-off-by: Patrik Nyström <[email protected]> Co-authored-by: Sam DeHaan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable the receiver to consume fields from Cloudflare containing a map
Also added a configuration option for setting a separator where
.is defaultLink to tracking issue
Fixes #40318
Testing
Unit tests added