[receiver/statsd] allow customizing metric_type attribute name
#40339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonmei
force-pushed
the
feature/statsdreceiver-custom-metrictype-attr
branch
from
af8c2e2 to
ce3e5f7
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
neonmei
force-pushed
the
feature/statsdreceiver-custom-metrictype-attr
branch
from
4634b8f to
7a51923
Compare
This was referenced Jun 17, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the receiver allows annotating the
metric_typeby settingenable_metric_typetotrue. This attribute might be in use by an application and should be customizable.This PR introduces a new
metric_type_attributewhich allows using a custom attribute name for users that may be already be usingmetric_typefor their metrics.Link to tracking issue
No tracking issue
Testing
Added a couple of test cases which validate the attribute is set to the custom name, the case where the attribute is unset is already thoroughly tested.
Documentation
Documented the new
metric_type_attributein the README.me