[internal/aws] migrate to AWS v2 SDK #40123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/awscontainerinsight
exporter/awsxray
exporter/awsemf
github-actions
bot
requested review from
boostchicken,
pxaws,
rapphil,
srprash and
wangzlei
This commit addresses several lint issues identified during the AWS SDK v1 to v2 migration process: 1. Remove unused context parameters in AWS utility functions 2. Fix formatting issues with gci 3. Use appropriate assertion methods in tests
…metry-collector-contrib into 37728_internal-aws
BackendConnectionErrors.OtherCount was 1 in version 1, but HTTPCode4XXCount was 1 more after v2 conversion
seongpil0948
commented
May 22, 2025
| @@ -90,7 +90,8 @@ func TestTelemetryEnabled(t *testing.T) { | |||
| assert.EqualValues(t, 1, sink.StopCount.Load()) | |||
| assert.True(t, sink.HasRecording()) | |||
| got := sink.Rotate() | |||
| assert.EqualValues(t, 0, *got.BackendConnectionErrors.HTTPCode4XXCount) | |||
| assert.EqualValues(t, 1, *got.BackendConnectionErrors.HTTPCode4XXCount) | |||
There was a problem hiding this comment.
BackendConnectionErrors.OtherCount was 1 in version 1, but HTTPCode4XXCount was 1 more after v2 conversion
…ace from cn.getEC2Region to WithEC2IMDSRegion option
songy23
added
dependencies
songy23
reviewed
May 29, 2025
There was a problem hiding this comment.
linters are failing: http://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/15322638726/job/43122189337?pr=40123
also need make gotidy
seongpil0948
force-pushed
the
37728_internal-aws
branch
from
c900ab7 to
ed2450b
Compare
mjlshen
suggested changes
May 31, 2025
Co-authored-by: Michael Shen <[email protected]>
To be honest, I'm very lucky to have met you. |
mjlshen
approved these changes
May 31, 2025
|
Thank you @seongpil0948 💯 |
|
I'm planning to merge this PR by Friday 6/6 since AWS SDK v1 is approaching EOL soon. Please leave a comment before then if you think otherwise |
|
Thanks for your contributions @seongpil0948 ! |
Thank you to everyone who helped me with my first life contribution @mjlshen |
rockdaboot
pushed a commit
to rockdaboot/opentelemetry-collector-contrib
that referenced
this pull request
Jun 10, 2025
#### Description aws-sdk-go is being [deprecated on July 31, 2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/). this PR updates `internal/aws/awsutil` to aws-sdk-go-v2 and Update the modules that depend on them has improved the existing partition, sts related logic <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37728 <!--Describe what testing was performed and which tests were added.--> #### Testing I converted the existing unit test to aws-sdk-go-v2 as well, imorove partition related test <!--Describe the documentation added.--> #### Documentation - [internal endpoints module](https://pkg.go.dev/github.com/aws/[email protected]/internal/endpoints) --------- Co-authored-by: Michael Shen <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
#### Description aws-sdk-go is being [deprecated on July 31, 2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/). this PR updates `internal/aws/awsutil` to aws-sdk-go-v2 and Update the modules that depend on them has improved the existing partition, sts related logic <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37728 <!--Describe what testing was performed and which tests were added.--> #### Testing I converted the existing unit test to aws-sdk-go-v2 as well, imorove partition related test <!--Describe the documentation added.--> #### Documentation - [internal endpoints module](https://pkg.go.dev/github.com/aws/[email protected]/internal/endpoints) --------- Co-authored-by: Michael Shen <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aws-sdk-go is being deprecated on July 31, 2025.
this PR updates
internal/aws/awsutilto aws-sdk-go-v2 and Update the modules that depend on themhas improved the existing partition, sts related logic
Link to tracking issue
Fixes #37728
Testing
I converted the existing unit test to aws-sdk-go-v2 as well, imorove partition related test
Documentation