-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[chore] [receiver/hostmetrics] Remove any references to uptimescraper
#40093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I renamed this scraper to `system`, but neglected to remove a number of references to the old `uptimescraper` name. While I was here, I also cleaned up some OS support problems where there wasn't proper guarding, but it never showed up cause it's supported on the 3 OS's we run tests on.
atoulme
approved these changes
May 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seongpil0948
pushed a commit
to seongpil0948/opentelemetry-collector-contrib
that referenced
this pull request
May 16, 2025
…r` (open-telemetry#40093) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description I renamed this scraper to `system`, but neglected to remove a number of references to the old `uptimescraper` name. While I was here, I also cleaned up some OS support problems where there wasn't proper guarding, but it never showed up cause it's supported on the 3 OS's we run tests on. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40092 <!--Describe what testing was performed and which tests were added.--> #### Testing Locally ran all tests and integration tests.
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…r` (open-telemetry#40093) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description I renamed this scraper to `system`, but neglected to remove a number of references to the old `uptimescraper` name. While I was here, I also cleaned up some OS support problems where there wasn't proper guarding, but it never showed up cause it's supported on the 3 OS's we run tests on. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40092 <!--Describe what testing was performed and which tests were added.--> #### Testing Locally ran all tests and integration tests.
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…r` (open-telemetry#40093) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description I renamed this scraper to `system`, but neglected to remove a number of references to the old `uptimescraper` name. While I was here, I also cleaned up some OS support problems where there wasn't proper guarding, but it never showed up cause it's supported on the 3 OS's we run tests on. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40092 <!--Describe what testing was performed and which tests were added.--> #### Testing Locally ran all tests and integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready to merge
Code review completed; ready to merge by maintainers
receiver/hostmetrics/internal/scraper/system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I renamed this scraper to
system
, but neglected to remove a number of references to the olduptimescraper
name. While I was here, I also cleaned up some OS support problems where there wasn't proper guarding, but it never showed up cause it's supported on the 3 OS's we run tests on.Link to tracking issue
Fixes #40092
Testing
Locally ran all tests and integration tests.