Skip to content

[chore] [receiver/hostmetrics] Remove any references to uptimescraper #40093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025

Conversation

braydonk
Copy link
Contributor

Description

I renamed this scraper to system, but neglected to remove a number of references to the old uptimescraper name. While I was here, I also cleaned up some OS support problems where there wasn't proper guarding, but it never showed up cause it's supported on the 3 OS's we run tests on.

Link to tracking issue

Fixes #40092

Testing

Locally ran all tests and integration tests.

I renamed this scraper to `system`, but neglected to remove a number of
references to the old `uptimescraper` name. While I was here, I also
cleaned up some OS support problems where there wasn't proper guarding,
but it never showed up cause it's supported on the 3 OS's we run tests
on.
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braydonk braydonk added the ready to merge Code review completed; ready to merge by maintainers label May 16, 2025
@songy23 songy23 merged commit aa5c3aa into open-telemetry:main May 16, 2025
184 checks passed
@github-actions github-actions bot added this to the next release milestone May 16, 2025
seongpil0948 pushed a commit to seongpil0948/opentelemetry-collector-contrib that referenced this pull request May 16, 2025
…r` (open-telemetry#40093)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
I renamed this scraper to `system`, but neglected to remove a number of
references to the old `uptimescraper` name. While I was here, I also
cleaned up some OS support problems where there wasn't proper guarding,
but it never showed up cause it's supported on the 3 OS's we run tests
on.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#40092

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Locally ran all tests and integration tests.
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
…r` (open-telemetry#40093)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
I renamed this scraper to `system`, but neglected to remove a number of
references to the old `uptimescraper` name. While I was here, I also
cleaned up some OS support problems where there wasn't proper guarding,
but it never showed up cause it's supported on the 3 OS's we run tests
on.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#40092

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Locally ran all tests and integration tests.
dd-jasminesun pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2025
…r` (open-telemetry#40093)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
I renamed this scraper to `system`, but neglected to remove a number of
references to the old `uptimescraper` name. While I was here, I also
cleaned up some OS support problems where there wasn't proper guarding,
but it never showed up cause it's supported on the 3 OS's we run tests
on.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#40092

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Locally ran all tests and integration tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/hostmetrics/internal/scraper/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/hostmetrics] systemscraper has some references to its old name
4 participants