[receiver/apachespark] Add application id filter #39936
Conversation
|
Please add a changelog. Please clarify in the README that the filters are a union, meaning all application names and IDs matching will be allowed. Since we already have application names, why add ids? |
|
Please fix CI and address feedback, and move back to ready for review when done. |
|
Sure. Feature I need: The start - end should be also span. But this is next change. |
NN---
changed the title
NN---
force-pushed
the
apachespark_application_id
branch
from
a1c20b5 to
7a3fc42
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Don't close |
|
@NN--- I believe this is still waiting on addressing the feedback above from @\atoulme
Also pinging the codeowners to see if you can get codeowner review @mrsillydog @Caleb-Hurshman |
| for _, name := range s.config.ApplicationNames { | ||
| if apps, ok := appMap[name]; ok { | ||
| if apps, ok := nameMap[name]; ok { | ||
| allowedApps = append(allowedApps, apps...) | ||
| } | ||
| } | ||
|
|
||
| // Add apps matching IDs | ||
| for _, id := range s.config.ApplicationIDs { | ||
| if apps, ok := idMap[id]; ok { | ||
| allowedApps = append(allowedApps, apps...) | ||
| } | ||
| } |
There was a problem hiding this comment.
If the user were to specify an app ID and an app name that both matched a single app, this would result in the app being added to allowedApps twice, and metrics being scraped for the same app twice. I think we should add some logic to prevent this case in order to make this a true union.
There was a problem hiding this comment.
I see that union is problematic.
Will make it interception.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
Add application ids filter.
Link to tracking issue
Fixes #39627
Testing
Run with application ids specified.
Documentation
Allow filtering Apache Spark receiver by application id in addition to application name.