-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[prometheusremotewritereceiver] add exponential histograms datapoints #39864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheusremotewritereceiver] add exponential histograms datapoints #39864
Conversation
Would appreciate the review from @carrieedwards @krajorama @ywwg and @ArthurSens |
Guys in the section prometheus metric points -> OLTP we just have a documentation talking about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start, however I've added some comments on high level.
…trib into add-histograms-datapoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent a very decent amount of time trying to review this PR and I feel like I don't have the necessary knowledge to do a decent review.
If @krajorama or @carrieedwards could do this for me so we can unblock your work, I'd be super grateful. In the meantime, I'll read up Carrie's document to learn more about this kind of histograms
Nice, Carry docs plus the krajo implementation here is the way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a couple of comments , should be close now.
…trib into add-histograms-datapoints
…lemetry-collector-contrib into add-histograms-datapoints
…lemetry-collector-contrib into add-histograms-datapoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversion LGTM.
I've tried testing with source->prometheus->otel collector->mimir , but had some issues around handling unsupported types (summary, classic histogram) which meant I couldn't test end to end, but the debug exporter showed that the conversion is ok.
Incidentally the debug exporter crashed for me consistently even without native histograms , so there's more to be fixed for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patience while working on this one, it sure wasn't easy :)
Description
This PR partially implements the native histograms from prometheus v2 to the Otel exponential histograms. For now, it's missing some implementations that I take care on a next PR. Like:
Link to tracking issue
Related to #37277