[receiver/datadogreceiver] Configure /intake endpoint
#39787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign the CLA. |
|
It is a WIP, I'll sign it as soon as I have approval. |
|
@atoulme CLA signed! |
|
Please address the build issues. |
receiver/datadogreceiver/receiver.go
Outdated
Comment on lines
517
to
518
| req.Header.Del("Dd-Api-Key") | ||
| req.Header.Add("Dd-Api-Key", key) |
There was a problem hiding this comment.
Any reason not use Set here? It should replace what currently exists and saves needed to delete the entry?
There was a problem hiding this comment.
Very true. This uses Set now.
goakley
requested review from
evan-bradley,
atoulme and
tigrannajaryan
as code owners
|
Can someone tell me how to retrigger the checks? They don't seem to be queued in GitHub Actions. |
|
@MovieStoreGuy please take another look. There are conflicts, but I'm not sure if it's appropriate to rebase before the review completes. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
goakley
force-pushed
the
datadogreceiver/intake-endpoint
branch
from
922cead to
13e1832
Compare
goakley
force-pushed
the
datadogreceiver/intake-endpoint
branch
2 times, most recently
from
ac752fc to
f0be05e
Compare
MovieStoreGuy
approved these changes
Jun 16, 2025
goakley
force-pushed
the
datadogreceiver/intake-endpoint
branch
from
f0be05e to
a164481
Compare
atoulme
added
ready to merge
|
Please review the CI build, address any issues, and mark ready for review again. |
Datadog's `/intake` endpoint is used by agents to record information about the system they're running on. It's not a metrics/logs/traces endpoint, but instead accepts metadata about a specific host that a `datadog-agent` is running on. This meatadata is used by Datadog to enrich metrics for a specific host (e.g. host-specific tags that should be associated with all metrics from that host). While supporting `/intake` isn't striclty necessary to ingest metrics/logs/traces, it means that [pointing a `datadog-agent` at an OpenTelemetry Collector](https://github.com/DataDog/datadog-agent/blob/7.64.0/pkg/config/config_template.yaml#L40) will not work as expected, because all metrics submitted by the agent will be missing their host tags. By adding the ability to proxy `/intake` calls to Datadog itself, we enable this `datadog-agent`→`otelcol` workflow.
goakley
force-pushed
the
datadogreceiver/intake-endpoint
branch
from
bd3832a to
43ef34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Datadog's
/intakeendpoint is used by agents to record information about the system they're running on. It's not a metrics/logs/traces endpoint, but instead accepts metadata about a specific host that adatadog-agentis running on. This meatadata is used by Datadog to enrich metrics for a specific host (e.g. host-specific tags that should be associated with all metrics from that host).While supporting
/intakeisn't striclty necessary to ingest metrics/logs/traces, it means that pointing adatadog-agentat an OpenTelemetry Collector will not work as expected, because all metrics submitted by the agent will be missing their host tags. By adding the ability to proxy/intakecalls to Datadog itself, we enable thisdatadog-agent→otelcolworkflow.The default behaviour maintains backwards-compatibility - if you don't specify an intake configuration, then intake calls aren't processed.
Testing
Ran both simulated calls and ran a
datadog-agentagainst this receiver. The collector properly received and proxied the/intakecalls (as could be seen in the Datadog hosts dashboard).Documentation
Updated the README for the receiver.