-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[receiver/awsxray] update to aws-sdk-go-v2 #39717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
636e5e3
to
4076500
Compare
Please address conflicts |
d2e5ed5
to
a48627a
Compare
@mxiamxia and @Aneurysm9 please review |
Please address the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@mjlshen please address the conflict and we can get the changes in. |
Signed-off-by: Michael Shen <[email protected]>
Signed-off-by: Michael Shen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mjlshen!
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description aws-sdk-go is being [deprecated on July 31, 2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/). This PR updates `receiver/awsxray` and finishes updating `internal/aws/xray` to aws-sdk-go-v2. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37732 <!--Describe what testing was performed and which tests were added.--> #### Testing I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests. --------- Signed-off-by: Michael Shen <[email protected]>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description aws-sdk-go is being [deprecated on July 31, 2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/). This PR updates `receiver/awsxray` and finishes updating `internal/aws/xray` to aws-sdk-go-v2. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37732 <!--Describe what testing was performed and which tests were added.--> #### Testing I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests. --------- Signed-off-by: Michael Shen <[email protected]>
Description
aws-sdk-go is being deprecated on July 31, 2025. This PR updates
receiver/awsxray
and finishes updatinginternal/aws/xray
to aws-sdk-go-v2.Link to tracking issue
Fixes #37732
Testing
I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests.