[receiver/azuremonitor] Add support for azureauthextension #39658
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
| component: azuremonitorreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add support for azureauthextension as a token provider for azuremonitorreceiver. | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| issues: [39048] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | ||
|
|
||
| # If your change doesn't affect end users or the exported elements of any package, | ||
| # you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
| # Optional: The change log or logs in which this entry should be included. | ||
| # e.g. '[user]' or '[user, api]' | ||
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [user] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package azuremonitorreceiver | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "path/filepath" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "go.opentelemetry.io/collector/component" | ||
| "go.opentelemetry.io/collector/confmap/confmaptest" | ||
| "go.opentelemetry.io/collector/confmap/xconfmap" | ||
|
|
||
| "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/azuremonitorreceiver/internal/metadata" | ||
| ) | ||
|
|
||
| func TestLoadConfig(t *testing.T) { | ||
|
There was a problem hiding this comment. Thanks for that! So cool to see some tests of this quality for the config :) |
||
| t.Parallel() | ||
|
|
||
| cm, err := confmaptest.LoadConf(filepath.Join("testdata", "config.yaml")) | ||
| require.NoError(t, err) | ||
|
|
||
| tests := []struct { | ||
| id component.ID | ||
| expected component.Config | ||
| expectedErr string | ||
| }{ | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "valid_subscription_ids"), | ||
| expected: func() component.Config { | ||
| cfg := createDefaultConfig().(*Config) | ||
| cfg.SubscriptionIDs = []string{"test"} | ||
| cfg.Credentials = defaultCredentials | ||
| return cfg | ||
| }(), | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "valid_discover_subscription"), | ||
| expected: func() component.Config { | ||
| cfg := createDefaultConfig().(*Config) | ||
| cfg.DiscoverSubscriptions = true | ||
| cfg.Credentials = defaultCredentials | ||
| return cfg | ||
| }(), | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "missing_subscription"), | ||
| expectedErr: errMissingSubscriptionIDs.Error(), | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "invalid_cloud"), | ||
| expectedErr: errInvalidCloud.Error(), | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "missing_service_principal"), | ||
| expectedErr: fmt.Sprintf( | ||
| "%s; %s; %s", | ||
| errMissingTenantID.Error(), | ||
| errMissingClientID.Error(), | ||
| errMissingClientSecret.Error(), | ||
| ), | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "missing_service_principal"), | ||
| expectedErr: fmt.Sprintf( | ||
| "%s; %s; %s", | ||
| errMissingTenantID.Error(), | ||
| errMissingClientID.Error(), | ||
| errMissingClientSecret.Error(), | ||
| ), | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "missing_workload_identity"), | ||
| expectedErr: fmt.Sprintf( | ||
| "%s; %s; %s", | ||
| errMissingTenantID.Error(), | ||
| errMissingClientID.Error(), | ||
| errMissingFedTokenFile.Error(), | ||
| ), | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "invalid_credentials"), | ||
| expectedErr: `credentials "invalid" is not supported`, | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "valid_authenticator"), | ||
| expected: func() component.Config { | ||
| cfg := createDefaultConfig().(*Config) | ||
| cfg.DiscoverSubscriptions = true | ||
| cfg.Authentication = &AuthConfig{ | ||
| AuthenticatorID: component.MustNewIDWithName("azureauth", "monitor"), | ||
| } | ||
| cfg.Credentials = "does-not-matter" | ||
| return cfg | ||
| }(), | ||
| }, | ||
| { | ||
| id: component.NewIDWithName(metadata.Type, "valid_authenticator_2"), | ||
| expected: func() component.Config { | ||
| cfg := createDefaultConfig().(*Config) | ||
| cfg.DiscoverSubscriptions = true | ||
| cfg.Authentication = &AuthConfig{ | ||
| AuthenticatorID: component.MustNewID("azureauth"), | ||
| } | ||
| cfg.Credentials = "does-not-matter" | ||
| return cfg | ||
| }(), | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.id.Name(), func(t *testing.T) { | ||
| factory := NewFactory() | ||
| cfg := factory.CreateDefaultConfig() | ||
|
|
||
| sub, err := cm.Sub(tt.id.String()) | ||
| require.NoError(t, err) | ||
| require.NoError(t, sub.Unmarshal(cfg)) | ||
|
|
||
| err = xconfmap.Validate(cfg) | ||
| if tt.expectedErr != "" { | ||
| assert.ErrorContains(t, err, tt.expectedErr) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, tt.expected, cfg) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep just TenantID at this place? Just a nit but this will be clearer when we'll remove the deprecated part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course