[extension/opamp] Load TLS config only for wss and https endpoints #39516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaojeling
requested review from
evan-bradley,
tigrannajaryan and
a team
as code owners
atoulme
approved these changes
Apr 21, 2025
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…pen-telemetry#39516) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Loads TLS config for the OpAMP Extension's OpAMP agent only if the `server::ws::endpoint`/`server::http::endpoint` config is set to a URL with scheme `wss`/`https`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39515 <!--Describe what testing was performed and which tests were added.--> #### Testing - Added unit tests - Tested manually with the steps described in **Steps to Reproduce** in open-telemetry#39515 <!--Please delete paragraphs that you did not use before submitting.-->
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…pen-telemetry#39516) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Loads TLS config for the OpAMP Extension's OpAMP agent only if the `server::ws::endpoint`/`server::http::endpoint` config is set to a URL with scheme `wss`/`https`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39515 <!--Describe what testing was performed and which tests were added.--> #### Testing - Added unit tests - Tested manually with the steps described in **Steps to Reproduce** in open-telemetry#39515 <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loads TLS config for the OpAMP Extension's OpAMP agent only if the
server::ws::endpoint/server::http::endpointconfig is set to a URL with schemewss/https.Link to tracking issue
Fixes #39515
Testing