Skip to content

[extension/oauth2clientauthextension] Allow exporting of OAuth extension to re-use it in other components, required for #39248 #39514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

Schm1tz1
Copy link
Contributor

@Schm1tz1 Schm1tz1 commented Apr 21, 2025

Description

As discussed in issue #39248 - generic OAuth support for kafka exporter (to be extended/applied for receiver also).
This is only for exporting the OAuth class so we can re-use it. Only internal references changed as it was not imported up to now. Created as a separate PR (suggestion by @atoulme in PR #39482).

Link to tracking issue

Required for #39482 and #39248

Testing

Nothing to be changed, only existing test.

Documentation

Nothing to be changed.

@atoulme atoulme merged commit b3ac7e6 into open-telemetry:main Apr 22, 2025
186 of 187 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 22, 2025
akshays-19 pushed a commit to akshays-19/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2025
…ion to re-use it in other components, required for open-telemetry#39248 (open-telemetry#39514)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
As discussed in issue open-telemetry#39248 - generic OAuth support for kafka exporter
(to be extended/applied for receiver also).
This is only for exporting the OAuth class so we can re-use it. Only
internal references changed as it was not imported up to now. Created as
a separate PR (suggestion by @atoulme in PR open-telemetry#39482).

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Required for open-telemetry#39482 and open-telemetry#39248

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Nothing to be changed, only existing test.

<!--Describe the documentation added.-->
#### Documentation
Nothing to be changed.

<!--Please delete paragraphs that you did not use before submitting.-->
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
…ion to re-use it in other components, required for open-telemetry#39248 (open-telemetry#39514)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
As discussed in issue open-telemetry#39248 - generic OAuth support for kafka exporter
(to be extended/applied for receiver also).
This is only for exporting the OAuth class so we can re-use it. Only
internal references changed as it was not imported up to now. Created as
a separate PR (suggestion by @atoulme in PR open-telemetry#39482).

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Required for open-telemetry#39482 and open-telemetry#39248

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Nothing to be changed, only existing test.

<!--Describe the documentation added.-->
#### Documentation
Nothing to be changed.

<!--Please delete paragraphs that you did not use before submitting.-->
MovieStoreGuy pushed a commit that referenced this pull request Apr 24, 2025
… of OAuth extension to re-use it in other components, required for #39248" (#39607)

Reverts #39514 as
discussed as part of #39482.
@Schm1tz1 Schm1tz1 deleted the OAuth-extension-export branch April 25, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension/oauth2clientauth Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants