Skip to content

[chore] [exporter/awscloudwatchlogs] move @boostchicken and @rapphil to emeritus codeowners #39471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andrzej-stencel
Copy link
Member

@andrzej-stencel andrzej-stencel commented Apr 17, 2025

@boostchicken and @rapphil haven't been responding to issues and pull requests for a couple months now. See for example #30773, #31382, #37297, #39339.

@boostchicken, @rapphil, first of all thank you for all the work you've done! Please respond here or in CNCF Slack #otel-collector-dev if you want to keep being active codeowners. You are also welcome to respond and confirm being moved to emeritus.

Also marks the exporter as unmaintained and seeking new codeowners.

According to the docs on codeowners, this pull request should wait for 2 months before being merged.

…to emeritus codeowners

@boostchicken and @rapphil haven't been responding to issues and pull requests for a couple months now.
See for example open-telemetry#31382, open-telemetry#37297.
@boostchicken, @rapphil please respond here or in CNCF Slack #otel-collector-dev if you want to keep being codeowners.

Also marks the exporter as seeking new codeowners.
@andrzej-stencel andrzej-stencel requested a review from a team as a code owner April 17, 2025 11:26
@andrzej-stencel andrzej-stencel requested a review from mwear April 17, 2025 11:26
@github-actions github-actions bot added the exporter/awscloudwatchlogs awscloudwatchlogs exporter label Apr 17, 2025
@andrzej-stencel
Copy link
Member Author

I have pinged @boostchicken on CNCF Slack here https://cloud-native.slack.com/archives/C07CCCMRXBK/p1744889454285849, but couldn't identify @rapphil on Slack.

@rapphil
Copy link
Contributor

rapphil commented Apr 22, 2025

I haven't been pinged explicitly on slack.

I have question: what are the implications of removing code ownership without finding new owners?

@andrzej-stencel
Copy link
Member Author

I haven't been pinged explicitly on slack.

Hey @rapphil, thanks for answering here 👋 . As mentioned above, I wasn't able to identify your profile in the CNCF Slack.

I have question: what are the implications of removing code ownership without finding new owners?

According to the docs on stability levels:

A component identified as unmaintained does not have an active code owner. Such component may have never been assigned a code owner or a previously active code owner has not responded to requests for feedback within 6 weeks of being contacted. Issues and pull requests for unmaintained components will be labelled as such. After 3 months of being unmaintained, these components will be removed from official distribution.

@rapphil (and @boostchicken just as well) if you wish to continue to be a codeowner of the AWS CloudWatch Logs exporter and respond to issues and review pull requests, just say it and I'll be happy to close this PR without merging or to update it by keeping your name in.

Copy link
Contributor

github-actions bot commented May 7, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 7, 2025
@edmocosta edmocosta removed the Stale label May 7, 2025
@atoulme atoulme added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners ready to merge Code review completed; ready to merge by maintainers labels May 9, 2025
@atoulme
Copy link
Contributor

atoulme commented May 9, 2025

@andrzej-stencel please resolve the conflict?

@atoulme
Copy link
Contributor

atoulme commented May 9, 2025

Note for self to not merge this PR before June 17.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

The component not having any codeowners changes its status to unmaintained.
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 12, 2025
@github-actions github-actions bot removed the Stale label Jun 14, 2025
@andrzej-stencel
Copy link
Member Author

This can be merged tomorrow, June 17th - after the two months period.

@andrzej-stencel andrzej-stencel merged commit af7b258 into open-telemetry:main Jun 17, 2025
178 checks passed
@andrzej-stencel andrzej-stencel deleted the awscloudwatchlogs-codeowners branch June 17, 2025 09:33
@github-actions github-actions bot added this to the next release milestone Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants