Skip to content

[receiver/awscloudwatchreceiver] enable storage extension #39007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

csatib02
Copy link
Contributor

Description

This pull request enables the storage extension for the awscloudwatch receiver.
Previously, the receiver started collecting logs from time.Now().Add(-cfg.Logs.PollInterval). Unlike other receivers where the default behavior typically aims to retrieve all available logs by default, this receiver lacked flexibility. With the introduction of the storage extension, users now have more granular control over log collection.
To address this, I've added a new start_from field, allowing users to precisely specify their log retrieval preferences. This feature provides greater configuration options for users who want to limit log collection based on their specific requirements.

Link to tracking issue

Fixes: #32231

Testing

  • Added unit tests to validate the persistence behavior
  • Conducted thorough manual testing to ensure reliability

Documentation

  • Updated README.md with new configuration options and usage details

@csatib02 csatib02 requested a review from a team as a code owner March 27, 2025 12:08
@csatib02 csatib02 requested a review from edmocosta March 27, 2025 12:08
Copy link

linux-foundation-easycla bot commented Mar 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from schmikei March 27, 2025 12:08
@csatib02 csatib02 changed the title feat: enable storage extension for awscloudwatch receiver [receiver/awscloudwatchreceiver] enable storage extension Mar 27, 2025
@atoulme atoulme marked this pull request as draft April 4, 2025 21:57
@csatib02 csatib02 force-pushed the awscloudwatch-patches branch 2 times, most recently from f994162 to 0e10d21 Compare April 7, 2025 08:54
@csatib02 csatib02 marked this pull request as ready for review April 7, 2025 08:54
@csatib02 csatib02 requested a review from atoulme April 7, 2025 08:54
@csatib02 csatib02 force-pushed the awscloudwatch-patches branch 2 times, most recently from f0cca92 to f7e99fb Compare April 8, 2025 07:57
@atoulme atoulme marked this pull request as draft April 9, 2025 04:57
@atoulme
Copy link
Contributor

atoulme commented Apr 9, 2025

Please address review comments and the build, and mark the PR ready to review again.

@csatib02 csatib02 force-pushed the awscloudwatch-patches branch from f7e99fb to e135a62 Compare April 12, 2025 16:52
@csatib02 csatib02 marked this pull request as ready for review April 12, 2025 16:52
@csatib02 csatib02 requested a review from atoulme April 12, 2025 16:53
@csatib02 csatib02 force-pushed the awscloudwatch-patches branch from e135a62 to 9c685f9 Compare April 13, 2025 09:03
@csatib02 csatib02 force-pushed the awscloudwatch-patches branch from 9c685f9 to 386f4e3 Compare April 15, 2025 09:15
@csatib02 csatib02 requested a review from dehaansa April 15, 2025 15:12
Copy link
Contributor

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@csatib02 csatib02 force-pushed the awscloudwatch-patches branch from 386f4e3 to 5c9e9f8 Compare April 17, 2025 14:14
@csatib02 csatib02 requested a review from edmocosta April 17, 2025 14:18
@atoulme
Copy link
Contributor

atoulme commented Apr 19, 2025

@schmikei please review.

Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to getting around and implementing this. Just tested it out and seems good to me. Thanks for adding the startFrom parameter and everyone else for giving initial glances.

@csatib02 csatib02 force-pushed the awscloudwatch-patches branch from 5c9e9f8 to a4f25f7 Compare April 23, 2025 08:26
@csatib02 csatib02 force-pushed the awscloudwatch-patches branch from a4f25f7 to 89a6f8a Compare April 23, 2025 08:29
@dehaansa dehaansa added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels Apr 23, 2025
@atoulme atoulme merged commit cc3bf7d into open-telemetry:main Apr 24, 2025
187 of 189 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/awscloudwatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/awscloudwatch] Missing log stream events
7 participants