-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[receiver/awscloudwatchreceiver] enable storage extension #39007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f994162
to
0e10d21
Compare
f0cca92
to
f7e99fb
Compare
Please address review comments and the build, and mark the PR ready to review again. |
f7e99fb
to
e135a62
Compare
e135a62
to
9c685f9
Compare
9c685f9
to
386f4e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
386f4e3
to
5c9e9f8
Compare
@schmikei please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been meaning to getting around and implementing this. Just tested it out and seems good to me. Thanks for adding the startFrom
parameter and everyone else for giving initial glances.
Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
5c9e9f8
to
a4f25f7
Compare
Signed-off-by: Bence Csati <[email protected]>
a4f25f7
to
89a6f8a
Compare
Description
This pull request enables the storage extension for the
awscloudwatch
receiver.Previously, the receiver started collecting logs from
time.Now().Add(-cfg.Logs.PollInterval)
. Unlike other receivers where the default behavior typically aims to retrieve all available logs by default, this receiver lacked flexibility. With the introduction of the storage extension, users now have more granular control over log collection.To address this, I've added a new
start_from
field, allowing users to precisely specify their log retrieval preferences. This feature provides greater configuration options for users who want to limit log collection based on their specific requirements.Link to tracking issue
Fixes: #32231
Testing
Documentation
README.md
with new configuration options and usage details