[chore][ping code owners] Only get code owners for components #38862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
added
ci-cd
songy23
approved these changes
Mar 21, 2025
atoulme
approved these changes
Mar 21, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…elemetry#38862) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description After checking the component labels file, `COMPONENT` may be empty if the label added is not for a component. This is a valid and acceptable state. If the label does not correspond to a component, code owners don't need to be pinged. This is to fix the following [example failure](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13994662160/job/39186701459). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to open-telemetry#38622 Before the related PR the passed in component was checked to make sure it wasn't empty and passed directly to the `get-codeowners.sh` script, which fails if `COMPONENT` is empty, and returns an empty string successfully if the given label is not a component. After the change, `COMPONENT` is modified to potentially be empty, then passed to `get-codeowners.sh`. This is what caused the `1` return code. <!--Describe what testing was performed and which tests were added.--> #### Testing Tested locally with the label `os:windows`. The script passes with the change, failed before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After checking the component labels file,
COMPONENTmay be empty if the label added is not for a component. This is a valid and acceptable state. If the label does not correspond to a component, code owners don't need to be pinged.This is to fix the following example failure.
Link to tracking issue
Related to #38622
Before the related PR the passed in component was checked to make sure it wasn't empty and passed directly to the
get-codeowners.shscript, which fails ifCOMPONENTis empty, and returns an empty string successfully if the given label is not a component. After the change,COMPONENTis modified to potentially be empty, then passed toget-codeowners.sh. This is what caused the1return code.Testing
Tested locally with the label
os:windows. The script passes with the change, failed before.