[receiver/k8sobjectsreceiver] Handle missing objects via error_mode
#38851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ChrsMark,
dmitryax,
hvaghani221 and
TylerHelmuth
|
Not a big fan of bringing a language feature of ottl into an exporter. I think the k8sobjectsreceiver can create and maintain its own semantics. That said, will defer to codeowners. |
Yes, there are other components re-using that, but more closely related to OTTL maybe. I am fine re-implementing it for this receiver too, if that's the consensus. |
krisztianfekete
changed the title
error_mode
atoulme
reviewed
Mar 24, 2025
atoulme
reviewed
Mar 24, 2025
atoulme
reviewed
Mar 24, 2025
atoulme
reviewed
Mar 24, 2025
atoulme
reviewed
Mar 24, 2025
atoulme
reviewed
Mar 24, 2025
atoulme
reviewed
Mar 24, 2025
atoulme
reviewed
Mar 24, 2025
atoulme
reviewed
Mar 24, 2025
…) handling processing of objects
ChrsMark
reviewed
Apr 16, 2025
TylerHelmuth
pushed a commit
that referenced
this pull request
Apr 22, 2025
…ic config (#39469) #### Description Refactor Validate() to only validate static config without external calls to Kubernetes API server as discussed in #38851 (comment) Once this is merged, the PR linked above should introduce `error_mode` implemented in `start` too. #### Link to tracking issue It is related to the issue and follow-up PR mentioned above, but it doesn't fix the issue. #### Testing I've refactored the tests in config_test.go, so we are not testing object discovery and added new tests for additional failure modes. I've build a dev images, and validated that functionality is the same as before the refactor. #### Documentation This is a "breaking change" in a sense we are changing what we are validating in Validate. The new validation logic will not fail when objects are missing. The receiver will fail the same way in this case, but in `start`.
ChrsMark
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Thank's @krisztianfekete, overall looks good to me with few small suggestions.
Probably a make fmt will fix the lint errors.
ChrsMark
reviewed
Apr 23, 2025
ChrsMark
reviewed
Apr 24, 2025
iblancasa
reviewed
Apr 24, 2025
…related errors that should propagate regardless of error_mode
ChrsMark
reviewed
Apr 24, 2025
ChrsMark
reviewed
Apr 24, 2025
… interval in newReceiver, update README
iblancasa
approved these changes
Apr 24, 2025
ChrsMark
reviewed
Apr 25, 2025
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
…open-telemetry#38851) #### Description This PR adopts a similar logic to `ottl.ErrorMode` for `k8sobjectsreceiver`, enabling users to choose between ignoring, silencing, and propagating errors for missing objects. The default is `propagate`, therefore it is backward compatible with the current state. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#38803 <!--Describe what testing was performed and which tests were added.--> #### Testing Added tests, and also tested by building my own image and deployed into a Kubernetes cluster. <!--Describe the documentation added.--> #### Documentation I've updated `receiver/k8sobjectsreceiver/config.yaml` and README with the new config options. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adopts a similar logic to
ottl.ErrorModefork8sobjectsreceiver, enabling users to choose between ignoring, silencing, and propagating errors for missing objects.The default is
propagate, therefore it is backward compatible with the current state.Link to tracking issue
Fixes #38803
Testing
Added tests, and also tested by building my own image and deployed into a Kubernetes cluster.
Documentation
I've updated
receiver/k8sobjectsreceiver/config.yamland README with the new config options.