[connector/signaltometrics] Introduce optional config for attributes
#38830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
changed the title
optional config for attributes
This was referenced Mar 23, 2025
MovieStoreGuy
approved these changes
Mar 24, 2025
|
I'll wait for approval from the code owners before merging the changes. |
ChrsMark
approved these changes
Apr 7, 2025
|
@MovieStoreGuy, the code owner approval is in. Can we merge this now? I am hoping to have this available in the next release. |
ChrsMark
added
the
ready to merge
|
Looks good to go. I added |
|
There was a small compilation error due to #38643 PR merged - I have fixed it now, so should be good to go! |
|
The lint failures are unrelated to this PR and are coming from |
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
open-telemetry#38830) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description `optional` attribute filtering allows to preserve attributes as they are in the input signal. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#38600 <!--Describe what testing was performed and which tests were added.--> #### Testing Test cases added <!--Describe the documentation added.--> #### Documentation Updated readme. <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
open-telemetry#38830) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description `optional` attribute filtering allows to preserve attributes as they are in the input signal. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#38600 <!--Describe what testing was performed and which tests were added.--> #### Testing Test cases added <!--Describe the documentation added.--> #### Documentation Updated readme. <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
optionalattribute filtering allows to preserve attributes as they are in the input signal.Link to tracking issue
Fixes #38600
Testing
Test cases added
Documentation
Updated readme.